Skip to content

Commit c29deec

Browse files
gautierdagcarmocca
andauthored
fix mypy typing errors in lightning/trainer/optimizers.py (#13470)
Co-authored-by: Carlos Mocholí <[email protected]>
1 parent dd9fad4 commit c29deec

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ module = [
8686
"pytorch_lightning.trainer.connectors.callback_connector",
8787
"pytorch_lightning.trainer.connectors.data_connector",
8888
"pytorch_lightning.trainer.data_loading",
89-
"pytorch_lightning.trainer.optimizers",
9089
"pytorch_lightning.trainer.supporters",
9190
"pytorch_lightning.trainer.trainer",
9291
"pytorch_lightning.tuner.batch_size_scaling",

src/pytorch_lightning/trainer/optimizers.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,10 @@ def init_optimizers(self, model: Optional["pl.LightningModule"]) -> Tuple[List,
3737
"`TrainerOptimizersMixin.init_optimizers` was deprecated in v1.6 and will be removed in v1.8."
3838
)
3939
pl_module = self.lightning_module or model
40+
assert isinstance(pl_module, pl.LightningModule)
4041
return _init_optimizers_and_lr_schedulers(pl_module)
4142

42-
def convert_to_lightning_optimizers(self):
43+
def convert_to_lightning_optimizers(self) -> None:
4344
r"""
4445
.. deprecated:: v1.6
4546
`TrainerOptimizersMixin.convert_to_lightning_optimizers` was deprecated in v1.6 and will be removed in v1.8.
@@ -59,6 +60,6 @@ def _convert_to_lightning_optimizer(optimizer: Optimizer) -> LightningOptimizer:
5960
break
6061
return optimizer # type: ignore [return-value]
6162

62-
self.strategy._cached_lightning_optimizers = { # type: ignore [assignment]
63+
self.strategy._cached_lightning_optimizers = {
6364
idx: _convert_to_lightning_optimizer(opt) for idx, opt in enumerate(self.optimizers)
6465
}

0 commit comments

Comments
 (0)