Skip to content

Commit bc28576

Browse files
committed
Resolve a TODO
1 parent 44b2fb4 commit bc28576

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

pytorch_lightning/callbacks/model_checkpoint.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -579,13 +579,12 @@ def __resolve_ckpt_dir(self, trainer: "pl.Trainer") -> None:
579579
"""
580580
if self.dirpath is not None:
581581
return # short circuit
582-
# TODO: Adapt for trainer.loggers
583-
if trainer.logger:
582+
if trainer.loggers:
584583
if trainer.weights_save_path != trainer.default_root_dir:
585584
# the user has changed weights_save_path, it overrides anything
586585
save_dir = trainer.weights_save_path
587586
else:
588-
save_dir = trainer.logger.save_dir or trainer.default_root_dir
587+
save_dir = trainer.logger.save_dir if len(trainer.loggers) == 1 else trainer.default_root_dir
589588

590589
version = (
591590
trainer.logger.version

0 commit comments

Comments
 (0)