Skip to content

Commit b9f4e7c

Browse files
committed
remove obscure forward call in eval
1 parent b8171fd commit b9f4e7c

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

tests/trainer/test_trainer.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -926,12 +926,6 @@ def test_num_sanity_val_steps(tmpdir, limit_val_batches):
926926
assert trainer.num_sanity_val_steps == num_sanity_val_steps
927927
val_dataloaders = model.val_dataloader__multiple_mixed_length()
928928

929-
with patch.object(trainer, 'evaluation_forward', wraps=trainer.evaluation_forward) as mocked:
930-
trainer.fit(model, val_dataloaders=val_dataloaders)
931-
assert mocked.call_count == sum(
932-
min(num_sanity_val_steps, num_batches) for num_batches in trainer.num_val_batches
933-
)
934-
935929

936930
@pytest.mark.parametrize(['limit_val_batches'], [
937931
pytest.param(0.0), # this should run no sanity checks
@@ -956,10 +950,6 @@ def test_num_sanity_val_steps_neg_one(tmpdir, limit_val_batches):
956950
assert trainer.num_sanity_val_steps == float('inf')
957951
val_dataloaders = model.val_dataloader__multiple()
958952

959-
with patch.object(trainer, 'evaluation_forward', wraps=trainer.evaluation_forward) as mocked:
960-
trainer.fit(model, val_dataloaders=val_dataloaders)
961-
assert mocked.call_count == sum(trainer.num_val_batches)
962-
963953

964954
@pytest.mark.parametrize("trainer_kwargs,expected", [
965955
pytest.param(

0 commit comments

Comments
 (0)