Skip to content

Commit b26adda

Browse files
committed
ddp as extra script
1 parent daa47c9 commit b26adda

File tree

3 files changed

+32
-19
lines changed

3 files changed

+32
-19
lines changed

.drone.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ steps:
4444
- sh tests/special_tests.sh
4545
- coverage report
4646
- python -m pytest benchmarks pl_examples -v --maxfail=2 --durations=0
47+
- pl_examples/run_ddp-example.sh
4748
# see: https://docs.codecov.io/docs/merging-reports
4849
- codecov --token $CODECOV_TOKEN --flags=gpu,pytest --name="GPU-coverage" --env=linux --build $DRONE_BUILD_NUMBER --commit $DRONE_COMMIT
4950
# --build $DRONE_BUILD_NUMBER --branch $DRONE_BRANCH --commit $DRONE_COMMIT --tag $DRONE_TAG --pr $DRONE_PULL_REQUEST

pl_examples/run_ddp-example.sh

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
#!/bin/bash
2+
3+
ARGS_DEFAULT=" --default_root_dir %(tmpdir)s --max_epochs 1 --batch_size 32 --limit_train_batches 2 --limit_val_batches 2"
4+
ARGS_EXTRA_DDP=" --gpus 2 --accelerator ddp"
5+
ARGS_EXTRA_AMP=" --precision 16"
6+
7+
python pl_examples/basic_examples/simple_image_classifier.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP}
8+
python pl_examples/basic_examples/simple_image_classifier.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP} ${ARGS_EXTRA_AMP}
9+
python pl_examples/basic_examples/backbone_image_classifier.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP}
10+
python pl_examples/basic_examples/backbone_image_classifier.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP} ${ARGS_EXTRA_AMP}
11+
python pl_examples/basic_examples/autoencoder.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP}
12+
python pl_examples/basic_examples/autoencoder.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP} ${ARGS_EXTRA_AMP}

pl_examples/test_examples.py

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@
2424
--accelerator dp \
2525
"""
2626

27-
ARGS_DDP = ARGS_DEFAULT + """
28-
--gpus 2 \
29-
--accelerator ddp_spawn \
30-
"""
27+
# ARGS_DDP = ARGS_DEFAULT + """
28+
# --gpus 2 \
29+
# --accelerator ddp_spawn \
30+
# """
3131

3232
ARGS_AMP = """
3333
--precision 16 \
@@ -51,21 +51,21 @@ def test_examples_dp(tmpdir, import_cli, cli_args):
5151
module.cli_main()
5252

5353

54-
@pytest.mark.parametrize('import_cli', [
55-
'pl_examples.basic_examples.simple_image_classifier',
56-
'pl_examples.basic_examples.backbone_image_classifier',
57-
'pl_examples.basic_examples.autoencoder',
58-
])
59-
@pytest.mark.skipif(torch.cuda.device_count() < 2, reason="test requires multi-GPU machine")
60-
@pytest.mark.parametrize('cli_args', [ARGS_DDP, ARGS_DDP + ARGS_AMP])
61-
def test_examples_ddp(tmpdir, import_cli, cli_args):
62-
63-
module = importlib.import_module(import_cli)
64-
# update the temp dir
65-
cli_args = cli_args % {'tmpdir': tmpdir}
66-
67-
with mock.patch("argparse._sys.argv", ["any.py"] + cli_args.strip().split()):
68-
module.cli_main()
54+
# @pytest.mark.parametrize('import_cli', [
55+
# 'pl_examples.basic_examples.simple_image_classifier',
56+
# 'pl_examples.basic_examples.backbone_image_classifier',
57+
# 'pl_examples.basic_examples.autoencoder',
58+
# ])
59+
# @pytest.mark.skipif(torch.cuda.device_count() < 2, reason="test requires multi-GPU machine")
60+
# @pytest.mark.parametrize('cli_args', [ARGS_DDP, ARGS_DDP + ARGS_AMP])
61+
# def test_examples_ddp(tmpdir, import_cli, cli_args):
62+
#
63+
# module = importlib.import_module(import_cli)
64+
# # update the temp dir
65+
# cli_args = cli_args % {'tmpdir': tmpdir}
66+
#
67+
# with mock.patch("argparse._sys.argv", ["any.py"] + cli_args.strip().split()):
68+
# module.cli_main()
6969

7070

7171
@pytest.mark.parametrize('import_cli', [

0 commit comments

Comments
 (0)