Skip to content

Commit a5235d5

Browse files
Remove model_connector.py (#10111)
1 parent 871a967 commit a5235d5

File tree

3 files changed

+10
-30
lines changed

3 files changed

+10
-30
lines changed

pytorch_lightning/trainer/connectors/data_connector.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
from dataclasses import dataclass
1616
from functools import partial
1717
from typing import Iterable, Optional, Union
18+
from weakref import proxy
1819

1920
import pytorch_lightning as pl
2021
from pytorch_lightning.utilities import rank_zero_deprecation
@@ -186,7 +187,15 @@ def attach_data(
186187
)
187188
self.attach_datamodule(model, datamodule=datamodule)
188189
# set local properties on the model
189-
self.trainer.model_connector.copy_trainer_model_properties(model)
190+
self._copy_trainer_model_properties(model)
191+
192+
def _copy_trainer_model_properties(self, model):
193+
ref_model = self.trainer.lightning_module or model
194+
195+
for m in [model, ref_model]:
196+
m.trainer = proxy(self.trainer)
197+
m.use_amp = self.trainer.amp_backend is not None
198+
m.precision = self.trainer.precision
190199

191200
def attach_dataloaders(
192201
self,

pytorch_lightning/trainer/connectors/model_connector.py

Lines changed: 0 additions & 27 deletions
This file was deleted.

pytorch_lightning/trainer/trainer.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@
5757
from pytorch_lightning.trainer.connectors.env_vars_connector import _defaults_from_env_vars
5858
from pytorch_lightning.trainer.connectors.logger_connector import LoggerConnector
5959
from pytorch_lightning.trainer.connectors.logger_connector.result import ResultCollection
60-
from pytorch_lightning.trainer.connectors.model_connector import ModelConnector
6160
from pytorch_lightning.trainer.connectors.signal_connector import SignalConnector
6261
from pytorch_lightning.trainer.connectors.training_trick_connector import TrainingTricksConnector
6362
from pytorch_lightning.trainer.data_loading import TrainerDataLoadingMixin
@@ -450,7 +449,6 @@ def __init__(
450449
plugins,
451450
)
452451
self.logger_connector = LoggerConnector(self, log_gpu_memory)
453-
self.model_connector = ModelConnector(self)
454452
self.callback_connector = CallbackConnector(self)
455453
self.debugging_connector = DebuggingConnector(self)
456454
self.training_tricks_connector = TrainingTricksConnector(self)

0 commit comments

Comments
 (0)