File tree Expand file tree Collapse file tree 2 files changed +2
-1
lines changed
pytorch_lightning/loops/epoch Expand file tree Collapse file tree 2 files changed +2
-1
lines changed Original file line number Diff line number Diff line change @@ -504,6 +504,7 @@ def _save_loggers_on_train_batch_end(self) -> None:
504504 """Flushes loggers to disk."""
505505 # when loggers should save to disk
506506 should_flush_logs = self .trainer .logger_connector .should_flush_logs
507+ # TODO: is_global_zero check should be moved to logger.save() implementation
507508 if should_flush_logs and self .trainer .is_global_zero :
508509 for logger in self .trainer .loggers :
509510 logger .save ()
Original file line number Diff line number Diff line change @@ -195,7 +195,7 @@ def test_name(tmpdir):
195195
196196
197197def test_version (tmpdir ):
198- """Verify names of loggers are concatenated properly."""
198+ """Verify versions of loggers are concatenated properly."""
199199 logger1 = CSVLogger (tmpdir , version = 0 )
200200 logger2 = CSVLogger (tmpdir , version = 2 )
201201 logger3 = CSVLogger (tmpdir , version = 1 )
You can’t perform that action at this time.
0 commit comments