Skip to content

Commit 9477d8d

Browse files
committed
remove deprecated sync step
1 parent 8473cf4 commit 9477d8d

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

pytorch_lightning/loggers/wandb.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ def __init__(
113113
log_model: Optional[bool] = False,
114114
experiment=None,
115115
prefix: Optional[str] = "",
116-
sync_step: Optional[bool] = None,
117116
**kwargs,
118117
):
119118
if wandb is None:
@@ -136,12 +135,6 @@ def __init__(
136135
"Hint: Upgrade with `pip install --ugrade wandb`."
137136
)
138137

139-
if sync_step is not None:
140-
warning_cache.deprecation(
141-
"`WandbLogger(sync_step=(True|False))` is deprecated in v1.2.1 and will be removed in v1.5."
142-
" Metrics are now logged separately and automatically synchronized."
143-
)
144-
145138
super().__init__()
146139
self._offline = offline
147140
self._log_model = log_model

tests/deprecated_api/test_remove_1-5.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
from pytorch_lightning import Callback, Trainer
2424
from pytorch_lightning.callbacks import ModelCheckpoint
2525
from pytorch_lightning.core.decorators import auto_move_data
26-
from pytorch_lightning.loggers import WandbLogger
2726
from pytorch_lightning.plugins import DeepSpeedPlugin
2827
from pytorch_lightning.profiler import AdvancedProfiler, BaseProfiler, PyTorchProfiler, SimpleProfiler
2928
from pytorch_lightning.utilities import device_parser
@@ -34,12 +33,6 @@
3433
from tests.helpers.utils import no_warning_call
3534

3635

37-
@mock.patch("pytorch_lightning.loggers.wandb.wandb")
38-
def test_v1_5_0_wandb_unused_sync_step(_):
39-
with pytest.deprecated_call(match=r"v1.2.1 and will be removed in v1.5"):
40-
WandbLogger(sync_step=True)
41-
42-
4336
def test_v1_5_0_old_callback_on_save_checkpoint(tmpdir):
4437
class OldSignature(Callback):
4538
def on_save_checkpoint(self, trainer, pl_module):

0 commit comments

Comments
 (0)