Skip to content

Commit 8cce188

Browse files
gautierdagawaelchli
authored andcommitted
Fix assert wandb Run when mode="disabled" (#14112)
1 parent c569fb3 commit 8cce188

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/pytorch_lightning/loggers/wandb.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ def __getstate__(self) -> Dict[str, Any]:
328328

329329
@property # type: ignore[misc]
330330
@rank_zero_experiment
331-
def experiment(self) -> Run:
331+
def experiment(self) -> Union[Run, RunDisabled]:
332332
r"""
333333
334334
Actual wandb object. To use wandb features in your
@@ -361,11 +361,13 @@ def experiment(self) -> Run:
361361
self._experiment = wandb.init(**self._wandb_init)
362362

363363
# define default x-axis
364-
if isinstance(self._experiment, Run) and getattr(self._experiment, "define_metric", None):
364+
if isinstance(self._experiment, (Run, RunDisabled)) and getattr(
365+
self._experiment, "define_metric", None
366+
):
365367
self._experiment.define_metric("trainer/global_step")
366368
self._experiment.define_metric("*", step_metric="trainer/global_step", step_sync=True)
367369

368-
assert isinstance(self._experiment, Run)
370+
assert isinstance(self._experiment, (Run, RunDisabled))
369371
return self._experiment
370372

371373
def watch(self, model: nn.Module, log: str = "gradients", log_freq: int = 100, log_graph: bool = True) -> None:

0 commit comments

Comments
 (0)