Skip to content

Commit 808534f

Browse files
kaushikb11lexierule
authored andcommitted
Pt 1.9 breaking fix: __iter__ type hint (#7993)
1 parent b46e213 commit 808534f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

pl_examples/domain_templates/reinforce_learn_Qnet.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
import argparse
3636
from collections import deque, namedtuple, OrderedDict
37-
from typing import List, Tuple
37+
from typing import Iterator, List, Tuple
3838

3939
import gym
4040
import numpy as np
@@ -139,7 +139,7 @@ def __init__(self, buffer: ReplayBuffer, sample_size: int = 200) -> None:
139139
self.buffer = buffer
140140
self.sample_size = sample_size
141141

142-
def __iter__(self) -> Tuple:
142+
def __iter__(self) -> Iterator:
143143
states, actions, rewards, dones, new_states = self.buffer.sample(self.sample_size)
144144
for i in range(len(dones)):
145145
yield states[i], actions[i], rewards[i], dones[i], new_states[i]

pl_examples/domain_templates/reinforce_learn_ppo.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
[3] https://github.com/sid-sundrani/ppo_lightning
2929
"""
3030
import argparse
31-
from typing import Callable, Iterable, List, Tuple
31+
from typing import Callable, Iterator, List, Tuple
3232

3333
import gym
3434
import torch
@@ -144,7 +144,7 @@ class ExperienceSourceDataset(IterableDataset):
144144
def __init__(self, generate_batch: Callable):
145145
self.generate_batch = generate_batch
146146

147-
def __iter__(self) -> Iterable:
147+
def __iter__(self) -> Iterator:
148148
iterator = self.generate_batch()
149149
return iterator
150150

0 commit comments

Comments
 (0)