Skip to content

Commit 38d3089

Browse files
committed
Invert if
1 parent 5fe6ad8 commit 38d3089

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

pytorch_lightning/callbacks/model_checkpoint.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -302,12 +302,10 @@ def on_train_epoch_end(
302302
# as we advance one step at end of training, we use `global_step - 1` to avoid saving duplicates
303303
trainer.train_loop.global_step -= 1
304304
if (
305-
self._should_skip_saving_checkpoint(trainer) or not self._save_on_train_epoch_end
306-
or self._every_n_epochs < 1 or (trainer.current_epoch + 1) % self._every_n_epochs != 0
305+
not self._should_skip_saving_checkpoint(trainer) and self._save_on_train_epoch_end
306+
and self._every_n_epochs > 0 and (trainer.current_epoch + 1) % self._every_n_epochs == 0
307307
):
308-
trainer.train_loop.global_step += 1
309-
return
310-
self.save_checkpoint(trainer)
308+
self.save_checkpoint(trainer)
311309
trainer.train_loop.global_step += 1
312310

313311
def on_validation_end(self, trainer: 'pl.Trainer', pl_module: 'pl.LightningModule') -> None:

0 commit comments

Comments
 (0)