Skip to content

Commit 1f58b9f

Browse files
authored
Merge branch 'master' into fix_metric_reset
2 parents 7caa72c + 0c7c9e8 commit 1f58b9f

File tree

16 files changed

+60
-91
lines changed

16 files changed

+60
-91
lines changed

docs/source/multi_gpu.rst

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -239,23 +239,6 @@ Note in particular the difference between `gpus=0`, `gpus=[0]` and `gpus="0"`.
239239
to be in "exclusive mode", such that only one process at a time can access them.
240240
For more details see the :ref:`Trainer guide <trainer>`.
241241

242-
243-
Remove CUDA flags
244-
^^^^^^^^^^^^^^^^^
245-
246-
CUDA flags make certain GPUs visible to your script.
247-
Lightning sets these for you automatically, there's NO NEED to do this yourself.
248-
249-
.. testcode::
250-
251-
# lightning will set according to what you give the trainer
252-
os.environ["CUDA_DEVICE_ORDER"] = "PCI_BUS_ID"
253-
os.environ["CUDA_VISIBLE_DEVICES"] = "0"
254-
255-
However, when using a cluster, Lightning will NOT set these flags (and you should not either).
256-
SLURM will set these for you.
257-
For more details see the :ref:`SLURM cluster guide <slurm>`.
258-
259242
----------
260243

261244
Distributed modes

pl_examples/basic_examples/autoencoder.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,16 @@
1515
from argparse import ArgumentParser
1616

1717
import torch
18-
import torch.nn.functional as F
1918
from torch import nn
20-
from torch.utils.data import DataLoader
21-
from torch.utils.data import random_split
19+
import torch.nn.functional as F
20+
from torch.utils.data import DataLoader, random_split
2221

22+
from pl_examples import cli_lightning_logo, TORCHVISION_AVAILABLE
2323
import pytorch_lightning as pl
24-
from pl_examples import TORCHVISION_AVAILABLE, cli_lightning_logo
2524

2625
if TORCHVISION_AVAILABLE:
27-
from torchvision.datasets.mnist import MNIST
2826
from torchvision import transforms
27+
from torchvision.datasets.mnist import MNIST
2928
else:
3029
from tests.base.datasets import MNIST
3130

pl_examples/basic_examples/backbone_image_classifier.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@
1818
from torch.nn import functional as F
1919
from torch.utils.data import DataLoader, random_split
2020

21+
from pl_examples import cli_lightning_logo, DATASETS_PATH, TORCHVISION_AVAILABLE
2122
import pytorch_lightning as pl
22-
from pl_examples import DATASETS_PATH, TORCHVISION_AVAILABLE, cli_lightning_logo
2323

2424
if TORCHVISION_AVAILABLE:
25-
from torchvision.datasets.mnist import MNIST
2625
from torchvision import transforms
26+
from torchvision.datasets.mnist import MNIST
2727
else:
2828
from tests.base.datasets import MNIST
2929

pl_examples/basic_examples/conv_sequential_example.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,16 @@
2020
To run:
2121
python conv_model_sequential_example.py --accelerator ddp --gpus 4 --max_epochs 1 --batch_size 256 --use_ddp_sequential
2222
"""
23-
import math
2423
from argparse import ArgumentParser
24+
import math
2525

2626
import torch
2727
import torch.nn as nn
2828
import torch.nn.functional as F
2929
import torchvision
3030

31-
import pytorch_lightning as pl
3231
from pl_examples import cli_lightning_logo
32+
import pytorch_lightning as pl
3333
from pytorch_lightning import Trainer
3434
from pytorch_lightning.metrics.functional import accuracy
3535
from pytorch_lightning.plugins.ddp_sequential_plugin import DDPSequentialPlugin

pl_examples/basic_examples/dali_image_classifier.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,29 +13,29 @@
1313
# limitations under the License.
1414
from abc import ABC
1515
from argparse import ArgumentParser
16+
from distutils.version import LooseVersion
1617
from random import shuffle
1718
from warnings import warn
18-
from distutils.version import LooseVersion
1919

2020
import numpy as np
2121
import torch
2222
from torch.nn import functional as F
2323
from torch.utils.data import random_split
2424

25+
from pl_examples import cli_lightning_logo, DALI_AVAILABLE, TORCHVISION_AVAILABLE
2526
import pytorch_lightning as pl
26-
from pl_examples import TORCHVISION_AVAILABLE, DALI_AVAILABLE, cli_lightning_logo
2727

2828
if TORCHVISION_AVAILABLE:
29-
from torchvision.datasets.mnist import MNIST
3029
from torchvision import transforms
30+
from torchvision.datasets.mnist import MNIST
3131
else:
3232
from tests.base.datasets import MNIST
3333

3434
if DALI_AVAILABLE:
35+
from nvidia.dali import __version__ as dali_version
3536
from nvidia.dali import ops
3637
from nvidia.dali.pipeline import Pipeline
3738
from nvidia.dali.plugin.pytorch import DALIClassificationIterator
38-
from nvidia.dali import __version__ as dali_version
3939

4040
NEW_DALI_API = LooseVersion(dali_version) >= LooseVersion('0.28.0')
4141
if NEW_DALI_API:

pl_examples/basic_examples/simple_image_classifier.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
import torch
1919
from torch.nn import functional as F
2020

21-
import pytorch_lightning as pl
2221
from pl_examples import cli_lightning_logo
2322
from pl_examples.basic_examples.mnist_datamodule import MNISTDataModule
23+
import pytorch_lightning as pl
2424

2525

2626
class LitClassifier(pl.LightningModule):

pl_examples/bug_report_model.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,12 @@
2020
# --------------------------------------------
2121
# --------------------------------------------
2222
import os
23+
2324
import torch
2425
from torch.utils.data import Dataset
2526

2627
from pl_examples import cli_lightning_logo
27-
from pytorch_lightning import Trainer, LightningModule
28+
from pytorch_lightning import LightningModule, Trainer
2829

2930

3031
class RandomDataset(Dataset):

pl_examples/domain_templates/computer_vision_fine_tuning.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,21 @@
3838
from collections import OrderedDict
3939
from pathlib import Path
4040
from tempfile import TemporaryDirectory
41-
from typing import Optional, Generator, Union
41+
from typing import Generator, Optional, Union
4242

4343
import torch
44-
import torch.nn.functional as F
4544
from torch import optim
4645
from torch.nn import Module
46+
import torch.nn.functional as F
4747
from torch.optim.lr_scheduler import MultiStepLR
4848
from torch.optim.optimizer import Optimizer
4949
from torch.utils.data import DataLoader
50-
from torchvision import models
51-
from torchvision import transforms
50+
from torchvision import models, transforms
5251
from torchvision.datasets import ImageFolder
5352
from torchvision.datasets.utils import download_and_extract_archive
5453

55-
import pytorch_lightning as pl
5654
from pl_examples import cli_lightning_logo
55+
import pytorch_lightning as pl
5756
from pytorch_lightning import _logger as log
5857

5958
BN_TYPES = (torch.nn.BatchNorm1d, torch.nn.BatchNorm2d, torch.nn.BatchNorm3d)

pl_examples/domain_templates/generative_adversarial_net.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,20 +19,20 @@
1919
2020
tensorboard --logdir default
2121
"""
22-
import os
2322
from argparse import ArgumentParser, Namespace
23+
import os
2424

2525
import numpy as np
2626
import torch
2727
import torch.nn as nn
2828
import torch.nn.functional as F # noqa
29-
import torchvision
30-
import torchvision.transforms as transforms
3129
from torch.utils.data import DataLoader
30+
import torchvision
3231
from torchvision.datasets import MNIST
32+
import torchvision.transforms as transforms
3333

3434
from pl_examples import cli_lightning_logo
35-
from pytorch_lightning.core import LightningModule, LightningDataModule
35+
from pytorch_lightning.core import LightningDataModule, LightningModule
3636
from pytorch_lightning.trainer import Trainer
3737

3838

pl_examples/domain_templates/imagenet.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030
python imagenet.py --help
3131
3232
"""
33-
import os
3433
from argparse import ArgumentParser, Namespace
34+
import os
3535

3636
import torch
3737
import torch.nn.functional as F
@@ -44,8 +44,8 @@
4444
import torchvision.models as models
4545
import torchvision.transforms as transforms
4646

47-
import pytorch_lightning as pl
4847
from pl_examples import cli_lightning_logo
48+
import pytorch_lightning as pl
4949
from pytorch_lightning.core import LightningModule
5050

5151

0 commit comments

Comments
 (0)