Skip to content

Commit 1c99b11

Browse files
committed
Merge branch 'master' into refactor/rename-creates-children
2 parents 90cadf8 + 9b21ecb commit 1c99b11

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

.github/workflows/ci_test-conda.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ jobs:
3131
python ./requirements/adjust_versions.py requirements/extra.txt
3232
python ./requirements/adjust_versions.py requirements/examples.txt
3333
pip install --requirement requirements/devel.txt --find-links https://download.pytorch.org/whl/nightly/torch_nightly.html
34+
pip install pytest-random-order
3435
pip list
3536
3637
- name: Pull checkpoints from S3
@@ -44,7 +45,7 @@ jobs:
4445
- name: Tests
4546
run: |
4647
# NOTE: run coverage on tests does not propagate failure status for Win, https://github.com/nedbat/coveragepy/issues/1003
47-
coverage run --source pytorch_lightning -m pytest pytorch_lightning tests -v --durations=50 --junitxml=junit/test-results-${{ runner.os }}-torch${{ matrix.pytorch-version }}.xml
48+
coverage run --source pytorch_lightning -m pytest --random-order-seed=1 pytorch_lightning tests -v --durations=50 --junitxml=junit/test-results-${{ runner.os }}-torch${{ matrix.pytorch-version }}.xml
4849
shell: bash -l {0}
4950

5051
- name: Upload pytest results

docs/source/common/trainer.rst

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,9 @@ Example::
516516
checkpoint_callback
517517
^^^^^^^^^^^^^^^^^^^
518518

519-
Deprecated: This has been deprecated in v1.5 and will be removed in v1.7. Please use ``enable_checkpointing`` instead.
519+
.. warning:: `checkpoint_callback` has been deprecated in v1.5 and will be removed in v1.7.
520+
To disable checkpointing, pass ``enable_checkpointing = False`` to the Trainer instead.
521+
520522

521523
default_root_dir
522524
^^^^^^^^^^^^^^^^

tests/profiler/test_profiler.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,7 @@ def test_pytorch_profiler_trainer_ddp(tmpdir, pytorch_profiler):
293293
assert any(f"{local_rank}-validation_step" in f for f in files)
294294

295295

296+
@RunIf(special=True)
296297
@pytest.mark.parametrize("fast_dev_run", [1, 2, 3, 4, 5])
297298
@pytest.mark.parametrize("boring_model_cls", [ManualOptimBoringModel, BoringModel])
298299
def test_pytorch_profiler_trainer_fit(fast_dev_run, boring_model_cls, tmpdir):

0 commit comments

Comments
 (0)