Skip to content

Commit 1ac2e7f

Browse files
committed
add note about #7677
1 parent 19754b5 commit 1ac2e7f

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

pytorch_lightning/loops/epoch_loop.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,8 @@ def on_advance_end(self):
158158
self.trainer._run_evaluation(on_epoch=True)
159159
self.trainer.training = True
160160

161-
# increment the global step once
162-
# progress global step according to grads progress
163161
# TODO: move inside training_loop.on_run_end? equivalent? order?
162+
# Needs to check batch_output signal -1, see #7677
164163
self.training_loop.increment_accumulated_grad_global_step()
165164

166165
# why is this not the same as the old on_train_epoch_end?

0 commit comments

Comments
 (0)