[DX] Reconfigure lint/format tasks to not run the command for each workspace, since Biome is super fast (also include bin and test JS files)

Kocal · Kocal · commit bc1d63cd9c04 · 2024-11-02T20:57:27.000+01:00
diff --git a/bin/build_package.js b/bin/build_package.js
@@ -38,12 +38,11 @@ async function main() {
     const srcDir = path.join(packageRoot, 'src');
     const distDir = path.join(packageRoot, 'dist');
 
-    
     if (!fs.existsSync(srcDir)) {
         console.error(`The package directory "${packageRoot}" does not contain a "src" directory.`);
         process.exit(1);
     }
-    
+
     if (fs.existsSync(distDir)) {
         console.log(`Cleaning up the "${distDir}" directory...`);
         await fs.promises.rm(distDir, { recursive: true });
@@ -53,41 +52,42 @@ async function main() {
     const inputScriptFiles = [
         ...glob.sync(path.join(srcDir, '*controller.ts')),
         ...(['@symfony/ux-react', '@symfony/ux-vue', '@symfony/ux-svelte'].includes(packageName)
-            ? [
-                path.join(srcDir, 'loader.ts'),
-                path.join(srcDir, 'components.ts'),
-            ]
+            ? [path.join(srcDir, 'loader.ts'), path.join(srcDir, 'components.ts')]
             : []),
         ...(packageName === '@symfony/stimulus-bundle'
-            ? [
-                path.join(srcDir, 'loader.ts'),
-                path.join(srcDir, 'controllers.ts'),
-            ] : []),
+            ? [path.join(srcDir, 'loader.ts'), path.join(srcDir, 'controllers.ts')]
+            : []),
     ];
-    
-    const inputStyleFile = packageData.config && packageData.config.css_source;
+
+    const inputStyleFile = packageData.config?.css_source;
     const buildCss = async () => {
-        const inputStyleFileDist = inputStyleFile ? path.resolve(distDir, `${path.basename(inputStyleFile, '.css')}.min.css`) : undefined;
+        const inputStyleFileDist = inputStyleFile
+            ? path.resolve(distDir, `${path.basename(inputStyleFile, '.css')}.min.css`)
+            : undefined;
         if (!inputStyleFile) {
             return;
         }
-        
+
         console.log('Minifying CSS...');
         const css = await fs.promises.readFile(inputStyleFile, 'utf-8');
         const minified = new CleanCSS().minify(css).styles;
         await fs.promises.writeFile(inputStyleFileDist, minified);
-    }
+    };
 
     if (inputScriptFiles.length === 0) {
-        console.error(`No input files found for package "${packageName}" (directory "${packageRoot}").\nEnsure you have at least a file matching the pattern "src/*_controller.ts", or manually specify input files in "${__filename}" file.`);
+        console.error(
+            `No input files found for package "${packageName}" (directory "${packageRoot}").\nEnsure you have at least a file matching the pattern "src/*_controller.ts", or manually specify input files in "${__filename}" file.`
+        );
         process.exit(1);
     }
 
     const rollupConfig = getRollupConfiguration({ packageRoot, inputFiles: inputScriptFiles });
 
     if (args.values.watch) {
-        console.log(`Watching for JavaScript${inputStyleFile ? ' and CSS' :  ''} files modifications in "${srcDir}" directory...`);
-        
+        console.log(
+            `Watching for JavaScript${inputStyleFile ? ' and CSS' : ''} files modifications in "${srcDir}" directory...`
+        );
+
         if (inputStyleFile) {
             rollupConfig.plugins = (rollupConfig.plugins || []).concat({
                 name: 'watcher',
@@ -96,7 +96,7 @@ async function main() {
                 },
             });
         }
-        
+
         const watcher = rollup.watch(rollupConfig);
         watcher.on('event', ({ result }) => {
             if (result) {
@@ -105,7 +105,7 @@ async function main() {
         });
         watcher.on('change', async (id, { event }) => {
             if (event === 'update') {
-                console.log(`Files were modified, rebuilding...`);
+                console.log('Files were modified, rebuilding...');
             }
 
             if (inputStyleFile && id === inputStyleFile) {
@@ -115,12 +115,12 @@ async function main() {
     } else {
         console.log(`Building JavaScript files from ${packageName} package...`);
         const start = Date.now();
-        
+
         const bundle = await rollup.rollup(rollupConfig);
         await bundle.write(rollupConfig.output);
-        
+
         await buildCss();
-        
+
         console.log(`Done in ${((Date.now() - start) / 1000).toFixed(3)} seconds.`);
     }
 }
diff --git a/bin/rollup.js b/bin/rollup.js
@@ -1,9 +1,9 @@
+const fs = require('node:fs');
+const path = require('node:path');
 const resolve = require('@rollup/plugin-node-resolve');
 const commonjs = require('@rollup/plugin-commonjs');
 const typescript = require('@rollup/plugin-typescript');
-const fs = require('fs');
 const glob = require('glob');
-const path = require('path');
 
 /**
  * Guarantees that any files imported from a peer dependency are treated as an external.
@@ -54,10 +54,15 @@ const moveTypescriptDeclarationsPlugin = (packageRoot) => ({
             const relativePath = file;
             // a bit odd, but remove first 7 or 4 directories, which will leave only the relative path to the file
             // ex: dist/Chartjs/assets/src/controller.d.ts' => 'dist/controller.d.ts'
-            const targetFile = relativePath.replace(relativePath.split('/').slice(1, isBridge ? 7 : 4).join('/') + '/', '');
-            
+            const targetFile = relativePath.replace(
+                `${relativePath
+                    .split('/')
+                    .slice(1, isBridge ? 7 : 4)
+                    .join('/')}/`,
+                ''
+            );
             if (!fs.existsSync(path.dirname(targetFile))) {
-               fs.mkdirSync(path.dirname(targetFile), { recursive: true });
+                fs.mkdirSync(path.dirname(targetFile), { recursive: true });
             }
             fs.renameSync(file, targetFile);
         });
@@ -81,15 +86,15 @@ function getRollupConfiguration({ packageRoot, inputFiles }) {
         if (file.includes('StimulusBundle/assets/src/loader.ts')) {
             peerDependencies.push('./controllers.js');
         }
-        
+
         // React, Vue
         if (file.includes('assets/src/loader.ts')) {
             peerDependencies.push('./components.js');
         }
     });
-    
+
     const outDir = path.join(packageRoot, 'dist');
-    
+
     return {
         input: inputFiles,
         output: {
@@ -106,7 +111,7 @@ function getRollupConfiguration({ packageRoot, inputFiles }) {
                 include: [
                     'src/**/*.ts',
                     // TODO: Remove for the next major release
-                    // "@rollup/plugin-typescript" v11.0.0 fixed an issue (https://github.com/rollup/plugins/pull/1310) that 
+                    // "@rollup/plugin-typescript" v11.0.0 fixed an issue (https://github.com/rollup/plugins/pull/1310) that
                     // cause a breaking change for UX React users, the dist file requires "react-dom/client" instead of "react-dom"
                     // and it will break for users using the Symfony AssetMapper without Symfony Flex (for automatic "importmap.php" upgrade).
                     '**/node_modules/react-dom/client.js',
diff --git a/biome.json b/biome.json
@@ -4,6 +4,8 @@
         "include": [
             "*.json",
             "*.md",
+            "bin/*.js",
+            "test/*.js",
             "src/*/*.json",
             "src/*/*/md",
             "src/*/assets/src/**",
diff --git a/package.json b/package.json
@@ -8,10 +8,10 @@
     "scripts": {
         "build": "yarn workspaces foreach -Apt run build",
         "test": "bin/run-vitest-all.sh",
-        "lint": "yarn workspaces foreach -Apt run lint",
-        "format": "yarn workspaces foreach -Apt run format",
-        "check-lint": "yarn workspaces foreach -Apt run check-lint",
-        "check-format": "yarn workspaces foreach -Apt run check-format"
+        "lint": "biome lint --write",
+        "format": "biome format --write",
+        "check-lint": "biome lint",
+        "check-format": "biome format"
     },
     "devDependencies": {
         "@babel/core": "^7.25.2",
diff --git a/test/setup.js b/test/setup.js
@@ -7,6 +7,4 @@
  * file that was distributed with this source code.
  */
 
-'use strict';
-
 import '@symfony/stimulus-testing/setup';
