Add PHP CS Fixer with basic config #817
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
PHP-CS-Fixer should just be removed IMO. Just extra guff to deal with locally. StyleCI can auto-apply fixes anyhoo. |
Collaborator
|
I'm with @GrahamCampbell on this one. Styleci currently does a great job checking all pull requests, so I would like to keep it that way. I'm ok with the other changes, so can you revert the change the |
Merged
Contributor
|
#821 replaces this. StyleCI isn't failing on the PR since PR analyses only analyze the changed files, but once it's merged, StyleCI will do a full push analysis, and those can be merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.