Added missing Apps endpoints #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
requested changes
Nov 1, 2019
Collaborator
|
Small change on the configure method requested, the rest of the PR looks good! |
Collaborator
|
@jamiehuson can you rebase you PR against the current master? And use the |
jamiehuson
force-pushed
the
apps/updated-endpoints
branch
from
5f43ffd to
73c2cbf
Compare
acrobat
requested changes
Nov 13, 2019
Collaborator
acrobat
left a comment
acrobat
left a comment
There was a problem hiding this comment.
2 small remarks, the rest of the PR looks good! 👍
acrobat
approved these changes
Nov 14, 2019
Collaborator
|
Thanks @jamiehuson! And congrats on your first contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Some endpoints available on https://developer.github.com/v3/apps/ are not available through this package. I also added the Accept header back for the preview Apps apis, which addresses this issue: #800
Considerations
I did not include Create Github App from App-Manifest because that flow required additional scoping to fully understand the flow, which was beyond the scope of my needs at this time.
Testing
I have included tests for all added endpoints.