added request params and headers to user followers calls #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
requested changes
Nov 27, 2017
lib/Github/Api/User.php
Outdated
| * @return array list of followed users | ||
| */ | ||
| public function following($username) | ||
| public function following($username, array $parameters = array(), array $requestHeaders = array()) |
Collaborator
There was a problem hiding this comment.
Use the short array syntax instead of array()
lib/Github/Api/User.php
Outdated
| * @return array list of following users | ||
| */ | ||
| public function followers($username) | ||
| public function followers($username, array $parameters = array(), array $requestHeaders = array()) |
Collaborator
There was a problem hiding this comment.
Use the short array syntax instead of array()
Contributor
Author
|
@acrobat I did it this way because it matches this signature. If I change it to use shorthand array here, it should also be changed in AbstractApi. |
Contributor
Author
|
I threw in the change you requested for this pull request |
Collaborator
|
Can you do it also for the second method? After that the pr is good to go! |
Contributor
Author
|
done and done. |
Collaborator
|
No I meant |
added 2 commits
November 27, 2017 16:06
Contributor
Author
|
sorry. I got confused. I reverted the change to the abstract and modified the line you were talking about. |
Contributor
Author
|
Is this PR ready to go? |
Collaborator
|
Yes, sorry for the delay! Thanks @miscbits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a non-breaking way to be able to add parameters and request headers to these two calls. In my honest opinion, this change should be applied to all calls since it allows users an easy way to set custom parameters that GitHub may add even if they don't get implemented in this package immediately. This change also does not affect users who simply use the setPerPage method so it is simply an alternate way to page as well.