Skip to content

Conversation

@Nyholm
Copy link
Collaborator

@Nyholm Nyholm commented Aug 1, 2016

Added docs as requested in #415

@cursedcoder
Copy link
Contributor

Would be good to cover a ctor method from https://github.com/KnpLabs/php-github-api/pull/419/files


```php
$client = new Github\Client();
echo $client->getApiVersion(); // prints "s3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s3?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, Im also working with AWS right now..

@Nyholm
Copy link
Collaborator Author

Nyholm commented Aug 1, 2016

These docs assume that PR #423 will be merged.

@cursedcoder cursedcoder merged commit 1f50d2d into KnpLabs:master Aug 1, 2016
@Nyholm Nyholm deleted the api-version branch August 1, 2016 10:16
@Nyholm
Copy link
Collaborator Author

Nyholm commented Aug 1, 2016

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants