Try to fix build in PHP 5.3 #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👎 |
Contributor
Author
|
@GrahamCampbell not awesome. Aggree. But this is the only way I see to continue support of PHP 5.3. (Otherwise it's time for new major release) Also please arg and not simply say 👎 . |
Contributor
|
You can support php 5.3 WITHOUT this change. |
Contributor
|
there is a difference between supporting PHP 5.3 and running tests in the 5.3.3 version on Travis. The 5.3 environment has openssl properly. Only 5.3.3 does not. I suggest simply removing 5.3.3 from the matrix, testing it only on an uptodate 5.3 version (as done for any other minor version of PHP) |
Nek-
force-pushed
the
fix/composer-for-php-5-3
branch
3 times, most recently
from
3d9ab2b to
0699ac8
Compare
Nek-
force-pushed
the
fix/composer-for-php-5-3
branch
from
0699ac8 to
b6535b2
Compare
Contributor
Author
|
So this should be merge :) . Ping @stof |
Contributor
|
👎 |
Contributor
|
@Nek- I would say yes. The 5.3.3 image on Travis is simply not usable as it does not have openssl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.