Skip to content

Bugfix creating env #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Bugfix creating env #1107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22cbc82
Bugfix creating env
SergkeiM Mar 9, 2023
ce974e1
fixed tests
SergkeiM Mar 9, 2023
8b365a3
added rawurlencode for $name
SergkeiM Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/Github/Api/Environment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public function all($username, $repository, array $params = [])
*/
public function show($username, $repository, $name)
{
return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/environments/'.$name);
return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/environments/'.rawurlencode($name));
}

/**
Expand All @@ -53,7 +53,7 @@ public function show($username, $repository, $name)
*/
public function createOrUpdate($username, $repository, $name, array $params = [])
{
return $this->put('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/environments', $params);
return $this->put('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/environments/'.rawurlencode($name), $params);
}

/**
Expand All @@ -65,6 +65,6 @@ public function createOrUpdate($username, $repository, $name, array $params = []
*/
public function remove(string $username, string $repository, string $name)
{
return $this->delete('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/environments/'.$name);
return $this->delete('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/environments/'.rawurlencode($name));
}
}
2 changes: 1 addition & 1 deletion test/Github/Tests/Api/EnvironmentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public function shouldCreateOrUpdateEnvironment()

$api->expects($this->once())
->method('put')
->with('/repos/KnpLabs/php-github-api/environments');
->with('/repos/KnpLabs/php-github-api/environments/production');

$api->createOrUpdate('KnpLabs', 'php-github-api', 'production');
}
Expand Down