bug #992 fixed php warning in GithubExceptionThrower (clxmstaab, acrobat)

This PR was squashed before being merged into the 2.x branch.

Discussion
----------

fixes
```
Warning: Illegal string offset 'code' in GithubExceptionThrower.php on line 59
```
when deleting a deployment which is not yet set to inactive, see #991

I guess the warning beeing fixed is not explicitly related to the new endpoint added in #991 but I experienced it in this case.

Commits
-------

2afb40c fixed php warning in GithubExceptionThrower
2b35311 added testcase
a54c223 Update lib/Github/HttpClient/Plugin/GithubExceptionThrower.php
e000f00 Update GithubExceptionThrower.php
0e0265f fix CS
1ae94ab Improve single message errors and testcase

Author: clxmstaab

lib/Github/HttpClient/Plugin/GithubExceptionThrower.php

@@ -59,7 +59,7 @@ public function doHandleRequest(RequestInterface $request, callable $next, calla
                 if (422 === $response->getStatusCode() && isset($content['errors'])) {
                     $errors = [];
                     foreach ($content['errors'] as $error) {
-                        switch ($error['code']) {
+                        switch ($error['code'] ?? null) {
                             case 'missing':
                                 $errors[] = sprintf('The %s %s does not exist, for resource "%s"', $error['field'], $error['value'], $error['resource']);
                                 break;
@@ -81,6 +81,12 @@ public function doHandleRequest(RequestInterface $request, callable $next, calla
                                 break;
 
                             default:
+                                if (is_string($error)) {
+                                    $errors[] = $error;
+
+                                    break;
+                                }
+
                                 if (isset($error['message'])) {
                                     $errors[] = $error['message'];
                                 }

test/Github/Tests/HttpClient/Plugin/GithubExceptionThrowerTest.php

@@ -37,7 +37,7 @@ public function testHandleRequest(ResponseInterface $response, ExceptionInterfac
         if ($exception) {
             $this->expectException(get_class($exception));
             $this->expectExceptionCode($exception->getCode());
-            $this->expectExceptionMessage($exception->getMessage());
+            $this->expectExceptionMessageRegExp('/'.preg_quote($exception->getMessage(), '/').'$/');
         }
 
         $plugin->doHandleRequest(
@@ -196,6 +196,22 @@ public static function responseProvider()
                 ),
                 'exception' => new \Github\Exception\RuntimeException('This endpoint requires you to be authenticated.', 401),
             ],
+            'Cannot delete active deployment' => [
+                'response' => new Response(
+                    422,
+                    [
+                        'content-type' => 'application/json',
+                    ],
+                    json_encode(
+                        [
+                            'message' => 'Validation Failed',
+                            'errors' => ['We cannot delete an active deployment unless it is the only deployment in a given environment.'],
+                            'documentation_url' => 'https://docs.github.com/rest/reference/repos#delete-a-deployment',
+                        ]
+                    )
+                ),
+                'exception' => new \Github\Exception\ValidationFailedException('Validation Failed: We cannot delete an active deployment unless it is the only deployment in a given environment.', 422),
+            ],
         ];
     }
 }