Update References to handle slashes in reference values

Author: cursedcoder

lib/Github/Api/GitData/References.php

@@ -28,7 +28,9 @@ public function tags($username, $repository)
 
     public function show($username, $repository, $reference)
     {
-        return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/refs/'.rawurlencode($reference));
+        $reference = $this->encodeReference($reference);
+
+        return $this->get('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/refs/'.$reference);
     }
 
     public function create($username, $repository, array $params)
@@ -46,11 +48,20 @@ public function update($username, $repository, $reference, array $params)
             throw new MissingArgumentException('sha');
         }
 
-        return $this->patch('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/refs/'.rawurlencode($reference), $params);
+        $reference = $this->encodeReference($reference);
+
+        return $this->patch('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/refs/'.$reference, $params);
     }
 
     public function remove($username, $repository, $reference)
     {
-        return $this->delete('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/refs/'.rawurlencode($reference));
+        $reference = $this->encodeReference($reference);
+
+        return $this->delete('repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/refs/'.$reference);
+    }
+
+    private function encodeReference($rawReference)
+    {
+        return implode('/', array_map('rawurlencode', explode('/', $rawReference)));
     }
 }

test/Github/Tests/Api/GitData/ReferencesTest.php

@@ -2,10 +2,24 @@
 
 namespace Github\Tests\Api;
 
-use Github\Tests\Api\TestCase;
-
 class ReferencesTest extends TestCase
 {
+    /**
+     * @test
+     */
+    public function shouldNotEscapeSlashesInReferences()
+    {
+        $expectedValue = array('reference' => 'some data');
+
+        $api = $this->getApiMock();
+        $api->expects($this->once())
+            ->method('get')
+            ->with('repos/l3l0/l3l0repo/git/refs/master/some%2A%26%40%23branch/dasd1212')
+            ->will($this->returnValue($expectedValue));
+
+        $this->assertEquals($expectedValue, $api->show('l3l0', 'l3l0repo', 'master/some*&@#branch/dasd1212'));
+    }
+
     /**
      * @test
      */