Add support for "before" parameter on Notification API (#724)

* Add support for "before" parameter on Notification API

add support for "before" paramaters on Notification API

add NotificationTest@shouldGetNotificationsBefore

* fix styling

Author: Steven Yung

lib/Github/Api/Notification.php

@@ -26,7 +26,7 @@ class Notification extends AbstractApi
      *
      * @return array array of notifications
      */
-    public function all($includingRead = false, $participating = false, DateTime $since = null)
+    public function all($includingRead = false, $participating = false, DateTime $since = null, DateTime $before = null)
     {
         $parameters = [
             'all' => $includingRead,
@@ -37,6 +37,10 @@ public function all($includingRead = false, $participating = false, DateTime $si
             $parameters['since'] = $since->format(DateTime::ISO8601);
         }
 
+        if ($before !== null) {
+            $parameters['before'] = $before->format(DateTime::ISO8601);
+        }
+
         return $this->get('/notifications', $parameters);
     }
 

test/Github/Tests/Api/NotificationTest.php

@@ -45,6 +45,27 @@ public function shouldGetNotificationsSince()
         $api->all(false, false, $since);
     }
 
+    /**
+     * @test
+     */
+    public function shouldGetNotificationsBefore()
+    {
+        $before = new DateTime('now');
+
+        $parameters = [
+            'all' => false,
+            'participating' => false,
+            'before' => $before->format(DateTime::ISO8601),
+        ];
+
+        $api = $this->getApiMock();
+        $api->expects($this->once())
+            ->method('get')
+            ->with('/notifications', $parameters);
+
+        $api->all(false, false, null, $before);
+    }
+
     /**
      * @test
      */