feature #1038 feat: Add visibility option to repo create (gerdemann)

This PR was merged into the 3.4.x-dev branch.

Discussion
----------



Commits
-------

a78ae66 feat: Add `visibility` option to repo create

Author: acrobat

lib/Github/Api/Repo.php

@@ -181,6 +181,7 @@ public function showById($id)
      * @param int         $teamId       The id of the team that will be granted access to this repository. This is only valid when creating a repo in an organization.
      * @param bool        $autoInit     `true` to create an initial commit with empty README, `false` for no initial commit
      * @param bool        $hasProjects  `true` to enable projects for this repository or false to disable them.
+     * @param string|null $visibility
      *
      * @return array returns repository data
      */
@@ -195,15 +196,16 @@ public function create(
         $hasDownloads = false,
         $teamId = null,
         $autoInit = false,
-        $hasProjects = true
+        $hasProjects = true,
+        $visibility = null
     ) {
         $path = null !== $organization ? '/orgs/'.$organization.'/repos' : '/user/repos';
 
         $parameters = [
             'name'          => $name,
             'description'   => $description,
             'homepage'      => $homepage,
-            'private'       => !$public,
+            'visibility'    => $visibility ?? ($public ? 'public' : 'private'),
             'has_issues'    => $hasIssues,
             'has_wiki'      => $hasWiki,
             'has_downloads' => $hasDownloads,

test/Github/Tests/Api/RepoTest.php

@@ -95,7 +95,7 @@ public function shouldCreateRepositoryUsingNameOnly()
                 'name'          => 'l3l0Repo',
                 'description'   => '',
                 'homepage'      => '',
-                'private'       => false,
+                'visibility'    => 'public',
                 'has_issues'    => false,
                 'has_wiki'      => false,
                 'has_downloads' => false,
@@ -121,7 +121,7 @@ public function shouldCreateRepositoryForOrganization()
                 'name'          => 'KnpLabsRepo',
                 'description'   => '',
                 'homepage'      => '',
-                'private'       => false,
+                'visibility'    => 'public',
                 'has_issues'    => false,
                 'has_wiki'      => false,
                 'has_downloads' => false,
@@ -133,6 +133,48 @@ public function shouldCreateRepositoryForOrganization()
         $this->assertEquals($expectedArray, $api->create('KnpLabsRepo', '', '', true, 'KnpLabs'));
     }
 
+    /**
+     * @test
+     */
+    public function shouldCreateRepositoryWithInternalVisibility()
+    {
+        $expectedArray = ['id' => 1, 'name' => 'KnpLabsRepo'];
+
+        $api = $this->getApiMock();
+        $api->expects($this->once())
+            ->method('post')
+            ->with('/user/repos', [
+                'name'          => 'KnpLabsRepo',
+                'description'   => '',
+                'homepage'      => '',
+                'has_issues'    => false,
+                'has_wiki'      => false,
+                'has_downloads' => false,
+                'auto_init'     => false,
+                'has_projects'  => true,
+                'visibility'    => 'internal',
+            ])
+            ->will($this->returnValue($expectedArray));
+
+        $this->assertEquals(
+            $expectedArray,
+            $api->create(
+                'KnpLabsRepo',
+                '',
+                '',
+                false,
+                null,
+                false,
+                false,
+                false,
+                null,
+                false,
+                true,
+                'internal'
+            )
+        );
+    }
+
     /**
      * @test
      */
@@ -329,7 +371,7 @@ public function shouldCreateUsingAllParams()
                 'name'          => 'l3l0Repo',
                 'description'   => 'test',
                 'homepage'      => 'http://l3l0.eu',
-                'private'       => true,
+                'visibility'    => 'private',
                 'has_issues'    => false,
                 'has_wiki'      => false,
                 'has_downloads' => false,