Avoid needing getPerPage and perPage

Co-Authored-By: Jeroen Thora <[email protected]>

Author: GrahamCampbell

lib/Github/Api/AbstractApi.php

@@ -4,13 +4,12 @@
 
 use Github\Client;
 use Github\HttpClient\Message\ResponseMediator;
-use ValueError;
 
 /**
  * @author Joseph Bielawski <[email protected]>
  * @author Graham Campbell <[email protected]>
  */
-abstract class AbstractApi implements ApiInterface
+abstract class AbstractApi
 {
     /**
      * The client instance.
@@ -29,19 +28,13 @@ abstract class AbstractApi implements ApiInterface
     /**
      * Create a new API instance.
      *
-     * @param Client   $client
-     * @param int|null $perPage
+     * @param Client $client
      *
      * @return void
      */
-    public function __construct(Client $client, int $perPage = null)
+    public function __construct(Client $client)
     {
-        if (null !== $perPage && ($perPage < 1 || $perPage > 100)) {
-            throw new ValueError(sprintf('%s::__construct(): Argument #2 ($perPage) must be between 1 and 100, or null', self::class));
-        }
-
         $this->client = $client;
-        $this->perPage = $perPage;
     }
 
     /**
@@ -64,38 +57,6 @@ protected function getApiVersion()
         return $this->client->getApiVersion();
     }
 
-    /**
-     * Get the number of values to fetch per page.
-     *
-     * @return int|null
-     */
-    protected function getPerPage()
-    {
-        return $this->perPage;
-    }
-
-    /**
-     * Create a new instance with the given page parameter.
-     *
-     * This must be an integer between 1 and 100.
-     *
-     * @param int|null $perPage
-     *
-     * @return static
-     */
-    public function perPage(?int $perPage)
-    {
-        if (null !== $perPage && ($perPage < 1 || $perPage > 100)) {
-            throw new ValueError(sprintf('%s::perPage(): Argument #1 ($perPage) must be between 1 and 100, or null', self::class));
-        }
-
-        $copy = clone $this;
-
-        $copy->perPage = $perPage;
-
-        return $copy;
-    }
-
     public function configure()
     {
     }

lib/Github/Api/ApiInterface.php

@@ -35,15 +35,15 @@ public function update(array $params)
      */
     public function emails()
     {
-        return new Emails($this->getClient(), $this->getPerPage());
+        return new Emails($this->getClient());
     }
 
     /**
      * @return Followers
      */
     public function follow()
     {
-        return new Followers($this->getClient(), $this->getPerPage());
+        return new Followers($this->getClient());
     }
 
     public function followers($page = 1)
@@ -71,23 +71,23 @@ public function issues(array $params = [], $includeOrgIssues = true)
      */
     public function keys()
     {
-        return new PublicKeys($this->getClient(), $this->getPerPage());
+        return new PublicKeys($this->getClient());
     }
 
     /**
      * @return Notifications
      */
     public function notifications()
     {
-        return new Notifications($this->getClient(), $this->getPerPage());
+        return new Notifications($this->getClient());
     }
 
     /**
      * @return Memberships
      */
     public function memberships()
     {
-        return new Memberships($this->getClient(), $this->getPerPage());
+        return new Memberships($this->getClient());
     }
 
     /**
@@ -147,15 +147,15 @@ public function repositories($type = 'owner', $sort = 'full_name', $direction =
      */
     public function watchers()
     {
-        return new Watchers($this->getClient(), $this->getPerPage());
+        return new Watchers($this->getClient());
     }
 
     /**
      * @return Starring
      */
     public function starring()
     {
-        return new Starring($this->getClient(), $this->getPerPage());
+        return new Starring($this->getClient());
     }
 
     /**

lib/Github/Api/CurrentUser.php

@@ -22,30 +22,30 @@ class Enterprise extends AbstractApi
      */
     public function stats()
     {
-        return new Stats($this->getClient(), $this->getPerPage());
+        return new Stats($this->getClient());
     }
 
     /**
      * @return License
      */
     public function license()
     {
-        return new License($this->getClient(), $this->getPerPage());
+        return new License($this->getClient());
     }
 
     /**
      * @return ManagementConsole
      */
     public function console()
     {
-        return new ManagementConsole($this->getClient(), $this->getPerPage());
+        return new ManagementConsole($this->getClient());
     }
 
     /**
      * @return UserAdmin
      */
     public function userAdmin()
     {
-        return new UserAdmin($this->getClient(), $this->getPerPage());
+        return new UserAdmin($this->getClient());
     }
 }

lib/Github/Api/Enterprise.php

@@ -177,6 +177,6 @@ public function unstar($id)
      */
     public function comments()
     {
-        return new Comments($this->getClient(), $this->getPerPage());
+        return new Comments($this->getClient());
     }
 }

lib/Github/Api/Gists.php

@@ -22,38 +22,38 @@ class GitData extends AbstractApi
      */
     public function blobs()
     {
-        return new Blobs($this->getClient(), $this->getPerPage());
+        return new Blobs($this->getClient());
     }
 
     /**
      * @return Commits
      */
     public function commits()
     {
-        return new Commits($this->getClient(), $this->getPerPage());
+        return new Commits($this->getClient());
     }
 
     /**
      * @return References
      */
     public function references()
     {
-        return new References($this->getClient(), $this->getPerPage());
+        return new References($this->getClient());
     }
 
     /**
      * @return Tags
      */
     public function tags()
     {
-        return new Tags($this->getClient(), $this->getPerPage());
+        return new Tags($this->getClient());
     }
 
     /**
      * @return Trees
      */
     public function trees()
     {
-        return new Trees($this->getClient(), $this->getPerPage());
+        return new Trees($this->getClient());
     }
 }

lib/Github/Api/GitData.php

@@ -176,7 +176,7 @@ public function unlock($username, $repository, $id)
      */
     public function comments()
     {
-        return new Comments($this->getClient(), $this->getPerPage());
+        return new Comments($this->getClient());
     }
 
     /**
@@ -188,7 +188,7 @@ public function comments()
      */
     public function events()
     {
-        return new Events($this->getClient(), $this->getPerPage());
+        return new Events($this->getClient());
     }
 
     /**
@@ -200,7 +200,7 @@ public function events()
      */
     public function labels()
     {
-        return new Labels($this->getClient(), $this->getPerPage());
+        return new Labels($this->getClient());
     }
 
     /**
@@ -212,7 +212,7 @@ public function labels()
      */
     public function milestones()
     {
-        return new Milestones($this->getClient(), $this->getPerPage());
+        return new Milestones($this->getClient());
     }
 
     /**
@@ -224,7 +224,7 @@ public function milestones()
      */
     public function assignees()
     {
-        return new Assignees($this->getClient(), $this->getPerPage());
+        return new Assignees($this->getClient());
     }
 
     /**
@@ -236,6 +236,6 @@ public function assignees()
      */
     public function timeline()
     {
-        return new Timeline($this->getClient(), $this->getPerPage());
+        return new Timeline($this->getClient());
     }
 }

lib/Github/Api/Issue.php

@@ -82,31 +82,31 @@ public function repositories($organization, $type = 'all', $page = 1, $sort = nu
      */
     public function members()
     {
-        return new Members($this->getClient(), $this->getPerPage());
+        return new Members($this->getClient());
     }
 
     /**
      * @return Hooks
      */
     public function hooks()
     {
-        return new Hooks($this->getClient(), $this->getPerPage());
+        return new Hooks($this->getClient());
     }
 
     /**
      * @return Teams
      */
     public function teams()
     {
-        return new Teams($this->getClient(), $this->getPerPage());
+        return new Teams($this->getClient());
     }
 
     /**
      * @return OutsideCollaborators
      */
     public function outsideCollaborators()
     {
-        return new OutsideCollaborators($this->getClient(), $this->getPerPage());
+        return new OutsideCollaborators($this->getClient());
     }
 
     /**

lib/Github/Api/Organization.php

@@ -40,6 +40,6 @@ public function deleteProject($id)
 
     public function columns()
     {
-        return new Columns($this->getClient(), $this->getPerPage());
+        return new Columns($this->getClient());
     }
 }

lib/Github/Api/Project/AbstractProjectApi.php

@@ -68,6 +68,6 @@ public function move($id, array $params)
 
     public function cards()
     {
-        return new Cards($this->getClient(), $this->getPerPage());
+        return new Cards($this->getClient());
     }
 }