Tests and catching of InvalidArgumentException within __call

Author: jbrooksuk

lib/Github/Client.php

@@ -315,6 +315,10 @@ public function getSupportedApiVersions()
      * @throws InvalidArgumentException
      */
     public function __call($name, $args) {
-        return $this->api($name);
+        try {
+            return $this->api($name);
+        } catch (InvalidArgumentException $e) {
+            throw new BadMethodCallException(sprintf('Undefined method called: "%s"', $name));
+        }
     }
 }

test/Github/Tests/ClientTest.php

@@ -124,6 +124,17 @@ public function shouldGetApiInstance($apiName, $class)
         $this->assertInstanceOf($class, $client->api($apiName));
     }
 
+    /**
+     * @test
+     * @dataProvider getApiClassesProvider
+     */
+    public function shouldGetMagicApiInstance($apiName, $class)
+    {
+        $client = new Client();
+
+        $this->assertInstanceOf($class, $client->$apiName());
+    }
+
     /**
      * @test
      * @expectedException InvalidArgumentException
@@ -142,9 +153,11 @@ public function getApiClassesProvider()
 
             array('me', 'Github\Api\CurrentUser'),
             array('current_user', 'Github\Api\CurrentUser'),
+            array('currentUser', 'Github\Api\CurrentUser'),
 
             array('git', 'Github\Api\GitData'),
             array('git_data', 'Github\Api\GitData'),
+            array('gitData', 'Github\Api\GitData'),
 
             array('gist', 'Github\Api\Gists'),
             array('gists', 'Github\Api\Gists'),
@@ -163,7 +176,9 @@ public function getApiClassesProvider()
             array('repositories', 'Github\Api\Repo'),
 
             array('pr', 'Github\Api\PullRequest'),
+            array('pullRequest', 'Github\Api\PullRequest'),
             array('pull_request', 'Github\Api\PullRequest'),
+            array('pullRequests', 'Github\Api\PullRequest'),
             array('pull_requests', 'Github\Api\PullRequest'),
 
             array('authorization', 'Github\Api\Authorizations'),