bug #908 [2.x] Use RFC3986 for building URI query strings (GrahamCampbell)

This PR was squashed before being merged into the 2.x branch.

Discussion
----------

#906, but for 2.x.

Commits
-------

1530c3f Update Authentication.php
6df6b9e Update AbstractApi.php

Author: GrahamCampbell

lib/Github/Api/AbstractApi.php

@@ -103,7 +103,7 @@ protected function get($path, array $parameters = [], array $requestHeaders = []
         }
 
         if (count($parameters) > 0) {
-            $path .= '?'.http_build_query($parameters);
+            $path .= '?'.http_build_query($parameters, '', '&', PHP_QUERY_RFC3986);
         }
 
         $response = $this->client->getHttpClient()->get($path, $requestHeaders);
@@ -126,7 +126,7 @@ protected function head($path, array $parameters = [], array $requestHeaders = [
             unset($parameters['ref']);
         }
 
-        return $this->client->getHttpClient()->head($path.'?'.http_build_query($parameters), $requestHeaders);
+        return $this->client->getHttpClient()->head($path.'?'.http_build_query($parameters, '', '&', PHP_QUERY_RFC3986), $requestHeaders);
     }
 
     /**

lib/Github/HttpClient/Plugin/Authentication.php

@@ -69,7 +69,7 @@ public function doHandleRequest(RequestInterface $request, callable $next, calla
                 ];
 
                 $query .= empty($query) ? '' : '&';
-                $query .= utf8_encode(http_build_query($parameters, '', '&'));
+                $query .= utf8_encode(http_build_query($parameters, '', '&', PHP_QUERY_RFC3986));
 
                 $uri = $uri->withQuery($query);
                 $request = $request->withUri($uri);