Merge pull request #840 from KnpLabs/analysis-YjOWdv

Apply fixes from StyleCI

Author: acrobat

lib/Github/Api/AbstractApi.php

@@ -126,9 +126,7 @@ protected function head($path, array $parameters = [], array $requestHeaders = [
             unset($parameters['ref']);
         }
 
-        $response = $this->client->getHttpClient()->head($path.'?'.http_build_query($parameters), $requestHeaders);
-
-        return $response;
+        return $this->client->getHttpClient()->head($path.'?'.http_build_query($parameters), $requestHeaders);
     }
 
     /**

lib/Github/Api/GitData/Blobs.php

@@ -43,9 +43,7 @@ public function configure($bodyType = null)
      */
     public function show($username, $repository, $sha)
     {
-        $response = $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/blobs/'.rawurlencode($sha));
-
-        return $response;
+        return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/git/blobs/'.rawurlencode($sha));
     }
 
     /**

lib/Github/Api/PullRequest/Review.php

@@ -171,7 +171,7 @@ public function dismiss($username, $repository, $pullRequest, $id, $message)
         }
 
         return $this->put('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/pulls/'.$pullRequest.'/reviews/'.$id.'/dismissals', [
-          'message' => $message,
+            'message' => $message,
         ]);
     }
 

lib/Github/Api/Repository/Assets.php

@@ -74,9 +74,7 @@ public function create($username, $repository, $id, $name, $contentType, $conten
         // Asset creation requires a separate endpoint, uploads.github.com.
         // Change the base url for the HTTP client temporarily while we execute
         // this request.
-        $response = $this->postRaw('https://uploads.github.com/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/releases/'.rawurlencode($id).'/assets?name='.$name, $content, ['Content-Type' => $contentType]);
-
-        return $response;
+        return $this->postRaw('https://uploads.github.com/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/releases/'.rawurlencode($id).'/assets?name='.$name, $content, ['Content-Type' => $contentType]);
     }
 
     /**

lib/Github/Api/Repository/Contents.php

@@ -102,8 +102,8 @@ public function create($username, $repository, $path, $content, $message, $branc
         $url = '/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/contents/'.rawurlencode($path);
 
         $parameters = [
-          'content' => base64_encode($content),
-          'message' => $message,
+            'content' => base64_encode($content),
+            'message' => $message,
         ];
 
         if (null !== $branch) {
@@ -178,9 +178,9 @@ public function update($username, $repository, $path, $content, $message, $sha,
         $url = '/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/contents/'.rawurlencode($path);
 
         $parameters = [
-          'content' => base64_encode($content),
-          'message' => $message,
-          'sha'     => $sha,
+            'content' => base64_encode($content),
+            'message' => $message,
+            'sha'     => $sha,
         ];
 
         if (null !== $branch) {
@@ -219,8 +219,8 @@ public function rm($username, $repository, $path, $message, $sha, $branch = null
         $url = '/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/contents/'.rawurlencode($path);
 
         $parameters = [
-          'message' => $message,
-          'sha'     => $sha,
+            'message' => $message,
+            'sha'     => $sha,
         ];
 
         if (null !== $branch) {

test/Github/Tests/Api/IssueTest.php

@@ -16,7 +16,7 @@ public function shouldGetIssues()
         ];
         $sentData = $data + [
             'page' => 1,
-            ];
+        ];
 
         $api = $this->getApiMock();
         $api->expects($this->once())
@@ -43,7 +43,7 @@ public function shouldGetIssuesUsingAdditionalParameters()
         ];
         $sentData = $data + [
             'page' => 1,
-            ];
+        ];
 
         $api = $this->getApiMock();
         $api->expects($this->once())

test/Github/Tests/Api/PullRequest/CommentsTest.php

@@ -14,7 +14,7 @@ class CommentsTest extends TestCase
     public function shouldGetAllReviewCommentsForAPullRequest()
     {
         $expectedValue = [
-                [
+            [
                 'url' => 'https://api.github.com/repos/octocat/Hello-World/pulls/comments/1',
                 'id' => 1,
                 'pull_request_review_id' => 42,

test/Github/Tests/Functional/CacheTest.php

@@ -61,7 +61,7 @@ private function getCurrentUserResponse($username)
         ];
 
         $body = \GuzzleHttp\Psr7\stream_for(json_encode([
-          'login' => $username,
+            'login' => $username,
         ]));
 
         return new Response(200, $headers, $body);