From 0237914fb37041aa6872a67c5877b4548f38bce2 Mon Sep 17 00:00:00 2001 From: Muhammad Date: Fri, 26 Apr 2024 10:36:00 +0530 Subject: [PATCH 1/3] feat:Enable workflowStatus listener for campaign workflow --- .../main/resources/siren/workflows/sirenCampaignWorkflow.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rest/src/main/resources/siren/workflows/sirenCampaignWorkflow.json b/rest/src/main/resources/siren/workflows/sirenCampaignWorkflow.json index b0246432ff..8bb5d16824 100644 --- a/rest/src/main/resources/siren/workflows/sirenCampaignWorkflow.json +++ b/rest/src/main/resources/siren/workflows/sirenCampaignWorkflow.json @@ -49,7 +49,7 @@ "outputParameters": {}, "schemaVersion": 2, "restartable": true, - "workflowStatusListenerEnabled": false, + "workflowStatusListenerEnabled": true, "ownerEmail": "admin@sirenapp.io", "timeoutSeconds": 0, "variables": {}, From 0481a37108c344887d91f0755b806be9a73b4f81 Mon Sep 17 00:00:00 2001 From: Muhammad Date: Fri, 26 Apr 2024 22:14:37 +0530 Subject: [PATCH 2/3] feat: Set provider node to be optional in siren campaign workflow --- .../main/resources/siren/workflows/sirenCampaignWorkflow.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rest/src/main/resources/siren/workflows/sirenCampaignWorkflow.json b/rest/src/main/resources/siren/workflows/sirenCampaignWorkflow.json index 8bb5d16824..aa5b54afef 100644 --- a/rest/src/main/resources/siren/workflows/sirenCampaignWorkflow.json +++ b/rest/src/main/resources/siren/workflows/sirenCampaignWorkflow.json @@ -23,7 +23,7 @@ }, "type": "SIMPLE", "startDelay": 0, - "optional": false, + "optional": true, "asyncComplete": false, "permissive": false } From 6c5c3302b9e79d3f08a3b128c10261d73cd7043a Mon Sep 17 00:00:00 2001 From: Muhammad Date: Sat, 27 Apr 2024 16:07:38 +0530 Subject: [PATCH 3/3] feat: Update finalize eventhandler and workflow --- .../eventhandlers/finalizeWorkflowExecutionEventHandler.json | 1 - .../siren/workflows/sirenFinalizeExecutionWorkflow.json | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/rest/src/main/resources/siren/eventhandlers/finalizeWorkflowExecutionEventHandler.json b/rest/src/main/resources/siren/eventhandlers/finalizeWorkflowExecutionEventHandler.json index 10a446ccec..d14435c114 100644 --- a/rest/src/main/resources/siren/eventhandlers/finalizeWorkflowExecutionEventHandler.json +++ b/rest/src/main/resources/siren/eventhandlers/finalizeWorkflowExecutionEventHandler.json @@ -12,7 +12,6 @@ "workflowId": "${workflowId}", "correlationId": "${correlationId}", "status": "${status}", - "workflowInput": "${input}", "output": "${output}", "reasonForIncompletion": "${reasonForIncompletion}", "executionTime": "${executionTime}", diff --git a/rest/src/main/resources/siren/workflows/sirenFinalizeExecutionWorkflow.json b/rest/src/main/resources/siren/workflows/sirenFinalizeExecutionWorkflow.json index cfaf4141fa..3c0373cb7c 100644 --- a/rest/src/main/resources/siren/workflows/sirenFinalizeExecutionWorkflow.json +++ b/rest/src/main/resources/siren/workflows/sirenFinalizeExecutionWorkflow.json @@ -9,8 +9,7 @@ "taskReferenceName": "finalize_workflow_execution_task_ref", "inputParameters": { "status": "${workflow.input.status}", - "externalExecutionId": "${workflow.input.workflowId}", - "input": "${workflow.input.workflowInput}" + "externalExecutionId": "${workflow.input.workflowId}" }, "type": "SIMPLE", "startDelay": 0,