Skip to content

Commit 9c60da0

Browse files
authored
fix: 5XX series issues (#8)
1 parent bee1be3 commit 9c60da0

File tree

1 file changed

+8
-4
lines changed
  • http-task/src/main/java/com/netflix/conductor/tasks/http

1 file changed

+8
-4
lines changed

http-task/src/main/java/com/netflix/conductor/tasks/http/HttpTask.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import org.springframework.http.*;
2626
import org.springframework.stereotype.Component;
2727
import org.springframework.util.MultiValueMap;
28-
import org.springframework.web.client.HttpClientErrorException;
28+
import org.springframework.web.client.HttpStatusCodeException;
2929
import org.springframework.web.client.RestClientException;
3030
import org.springframework.web.client.RestTemplate;
3131

@@ -120,8 +120,12 @@ public void start(WorkflowModel workflow, TaskModel task, WorkflowExecutor execu
120120
task.setReasonForIncompletion(response.body.toString());
121121
} else {
122122
task.setReasonForIncompletion(
123-
Objects.requireNonNullElse(
124-
response.reasonPhrase, "No response from the remote service"));
123+
String.format(
124+
"%d: %s",
125+
response.statusCode,
126+
Objects.requireNonNullElse(
127+
response.reasonPhrase,
128+
"No response from the remote service")));
125129
}
126130
task.setStatus(TaskModel.Status.FAILED);
127131
}
@@ -184,7 +188,7 @@ protected HttpResponse httpCall(Input input) throws Exception {
184188
HttpStatus.valueOf(responseEntity.getStatusCode().value()).getReasonPhrase();
185189
response.headers = responseEntity.getHeaders();
186190
return response;
187-
} catch (HttpClientErrorException ex) {
191+
} catch (HttpStatusCodeException ex) {
188192
response.headers = ex.getResponseHeaders();
189193
response.statusCode = ex.getStatusCode().value();
190194
response.reasonPhrase = ex.getStatusText();

0 commit comments

Comments
 (0)