Skip to content

Delay tensorflow_gcs_config import #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2020
Merged

Delay tensorflow_gcs_config import #849

merged 1 commit into from
Jul 2, 2020

Conversation

@rosbo
Copy link
Contributor

@rosbo rosbo commented Jul 1, 2020

Import tensorflow_gcs_config only when set_tensorflow_credential is called to prevent preloading TensorFlow.

BUG=159906185

@rosbo rosbo requested a review from vimota July 2, 2020 00:08
@rosbo
Copy link
Contributor Author

rosbo commented Jul 2, 2020

I will test manually in Kaggle notebook to make sure the following works:

from kaggle_secrets import UserSecretsClient
user_secrets = UserSecretsClient()
user_credential = user_secrets.get_gcloud_credential()

user_secrets.set_tensorflow_credential(user_credential)

Testing in progress...

@rosbo
Copy link
Contributor Author

rosbo commented Jul 2, 2020

I confirm it works.

vimota
vimota approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@vimota vimota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rosbo rosbo merged commit a901aa3 into master Jul 2, 2020
@rosbo rosbo deleted the fix-tensorflow-import branch July 2, 2020 00:35
@rosbo rosbo mentioned this pull request Jul 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vimota vimota vimota approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rosbo @vimota