Skip to content

Fix GIT_COMMIT environment variable #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2022
Merged

Fix GIT_COMMIT environment variable #1165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ ARG BUILD_DATE=unknown

LABEL git-commit=$GIT_COMMIT
Copy link

@jmasukawa jmasukawa May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Philmod Does the fact that this may now contain brackets change how this is used at all?

Copy link
Contributor Author

@Philmod Philmod May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It contains brackets because the { was before the $. It shouldn't contain these brackets anymore

Copy link

@jmasukawa jmasukawa May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 i just meant this other reference that also uses $GIT_COMMIT (LABEL, different than the one you changed). by it's name i imagine it's just cosmetic, but was curious.

LABEL build-date=$BUILD_DATE
ENV GIT_COMMIT={$GIT_COMMIT}
ENV GIT_COMMIT=${GIT_COMMIT}
ENV BUILD_DATE=${BUILD_DATE}

LABEL tensorflow-version=$TENSORFLOW_VERSION
Expand Down