Fix GIT_COMMIT environment variable #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosbo
approved these changes
May 24, 2022
djherbis
approved these changes
May 24, 2022
jmasukawa
reviewed
May 24, 2022
| ARG GIT_COMMIT=unknown | ||
| ARG BUILD_DATE=unknown | ||
|
|
||
| LABEL git-commit=$GIT_COMMIT |
There was a problem hiding this comment.
@Philmod Does the fact that this may now contain brackets change how this is used at all?
Contributor
Author
There was a problem hiding this comment.
It contains brackets because the { was before the $. It shouldn't contain these brackets anymore
There was a problem hiding this comment.
👍 i just meant this other reference that also uses $GIT_COMMIT (LABEL, different than the one you changed). by it's name i imagine it's just cosmetic, but was curious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.