From 02c7e8041bbdd463dcdd87ae8daab0d5aa5dac1f Mon Sep 17 00:00:00 2001 From: "Viral B. Shah" Date: Sat, 25 Jun 2022 09:32:18 -0400 Subject: [PATCH 1/2] Re-enable the float16 tests --- test/umfpack.jl | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/test/umfpack.jl b/test/umfpack.jl index a0b4c91c..2a4c7a67 100644 --- a/test/umfpack.jl +++ b/test/umfpack.jl @@ -264,9 +264,9 @@ end (Float32, Float64), (Float64, Float64), (Int, Float64), + (ComplexF16, ComplexF64), + (Float16, Float64), ] - # Remove 16-bit eltypes on Windows due to julia #45736 issue - !Sys.iswindows() && push!(testtypes, (ComplexF16, ComplexF64), (Float16, Float64)) for (Tin, Tout) in testtypes F = lu(sparse(fill(Tin(1), 1, 1))) @@ -342,8 +342,7 @@ end increment!([0,4,0,2,1,2,1,4,3,2,1,2]), [2.,1.,3.,4.,-1.,-3.,3.,9.,2.,1.,4.,2.], 5, 5) # Remove 16-bit eltypes on Windows due to julia #45736 issue - testtypes = [Float64, ComplexF64, Float32, ComplexF32] - !Sys.iswindows() && push!(testtypes, Float16, ComplexF16) + testtypes = [Float64, ComplexF64, Float32, ComplexF32, Float16, ComplexF16)] for Tv in testtypes for Ti in Base.uniontypes(UMFPACK.UMFITypes) A = convert(SparseMatrixCSC{Tv,Ti}, A0) From ecbdb54d56eb45684d27032d753c63dd363b5dad Mon Sep 17 00:00:00 2001 From: "Viral B. Shah" Date: Sat, 25 Jun 2022 09:52:07 -0400 Subject: [PATCH 2/2] Fix --- test/umfpack.jl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/umfpack.jl b/test/umfpack.jl index 2a4c7a67..aca320f6 100644 --- a/test/umfpack.jl +++ b/test/umfpack.jl @@ -341,8 +341,7 @@ end A1 = sparse(increment!([0,4,1,1,2,2,0,1,2,3,4,4]), increment!([0,4,0,2,1,2,1,4,3,2,1,2]), [2.,1.,3.,4.,-1.,-3.,3.,9.,2.,1.,4.,2.], 5, 5) - # Remove 16-bit eltypes on Windows due to julia #45736 issue - testtypes = [Float64, ComplexF64, Float32, ComplexF32, Float16, ComplexF16)] + testtypes = [Float64, ComplexF64, Float32, ComplexF32, Float16, ComplexF16] for Tv in testtypes for Ti in Base.uniontypes(UMFPACK.UMFITypes) A = convert(SparseMatrixCSC{Tv,Ti}, A0)