Skip to content

Conversation

tkf
Copy link
Member

@tkf tkf commented Oct 24, 2021

No description provided.

@tkf tkf marked this pull request as draft October 24, 2021 07:19
@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #458 (2cd54c1) into master (0f1ac43) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   88.92%   88.98%   +0.05%     
==========================================
  Files          39       39              
  Lines        2257     2269      +12     
==========================================
+ Hits         2007     2019      +12     
  Misses        250      250              
Impacted Files Coverage Δ
src/julia/tests/test_libjulia.py 100.00% <100.00%> (ø)
src/julia/tests/test_sysimage.py 97.67% <100.00%> (-2.33%) ⬇️
src/julia/tests/utils.py 100.00% <0.00%> (ø)
src/julia/tests/test_core.py 99.00% <0.00%> (+0.01%) ⬆️
src/julia/core.py 83.78% <0.00%> (+0.04%) ⬆️
src/julia/pseudo_python_cli.py 80.97% <0.00%> (+0.10%) ⬆️
src/julia/runtests.py 75.92% <0.00%> (+0.45%) ⬆️
src/julia/python_jl.py 84.37% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f1ac43...2cd54c1. Read the comment docs.

@tkf
Copy link
Member Author

tkf commented Oct 24, 2021

test_compiled_modules_no fails with

┌ Error: Failed to import PyCall
│   exception =
│    LoadError: could not load symbol "main":
│    /home/runner/work/pyjulia/pyjulia/.tox/py/bin/python: undefined symbol: main
│    Stacktrace:
│      [1] #dlsym#1
│        @ ./libdl.jl:59 [inlined]
│      [2] dlsym(hnd::Ptr{Nothing}, s::Symbol)
│        @ Base.Libc.Libdl ./libdl.jl:57
│      [3] top-level scope
│        @ ~/.julia/packages/PyCall/ScKXc/src/startup.jl:76
│      [4] include(mod::Module, _path::String)
│        @ Base ./Base.jl:420
│      [5] include(x::String)
│        @ PyCall ~/.julia/packages/PyCall/ScKXc/src/PyCall.jl:1
│      [6] top-level scope
│        @ ~/.julia/packages/PyCall/ScKXc/src/PyCall.jl:38
│      [7] include
│        @ ./Base.jl:420 [inlined]
│      [8] _require(pkg::Base.PkgId)
│        @ Base ./loading.jl:1149
│      [9] require(uuidkey::Base.PkgId)
│        @ Base ./loading.jl:1013
│     [10] top-level scope
│        @ none:3
│    in expression starting at /home/runner/.julia/packages/PyCall/ScKXc/src/startup.jl:41
│    in expression starting at /home/runner/.julia/packages/PyCall/ScKXc/src/PyCall.jl:1
└ @ Main none:5

https://github.com/JuliaPy/pyjulia/runs/3990728739?check_suite_focus=true#step:8:371 (Test ubuntu-latest x64 Python 3.10 Julia ~1.7.0-rc1)

Similar failure in
https://github.com/JuliaPy/pyjulia/runs/3990728717?check_suite_focus=true#step:8:368 (Test ubuntu-latest x64 Python 3.10 Julia 1.6)
https://github.com/JuliaPy/pyjulia/runs/3990728650?check_suite_focus=true#step:8:363 (Test ubuntu-latest x64 Python 3.9 Julia 1.0)
etc.

It looks like this occurs for all combinations with Python >= 3.9 in Linux.

This also breaks the sysimage tests since it uses --compiled-modules=no for Julia >= 1.5.

@tkf tkf marked this pull request as ready for review October 24, 2021 22:34
@tkf tkf changed the title Update Python versions Test with Python 3.9 and 3.10 Oct 24, 2021
@tkf tkf merged commit 11fed52 into JuliaPy:master Oct 24, 2021
@tkf tkf deleted the py310 branch October 24, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant