From a00e237d861a54d1b4f6cc244c07c76597ff0c97 Mon Sep 17 00:00:00 2001 From: hyrodium Date: Sun, 14 Apr 2024 00:06:10 +0900 Subject: [PATCH 1/5] Add tests with Aqua.jl --- Project.toml | 7 ++++++- test/runtests.jl | 4 +++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Project.toml b/Project.toml index da614a0f..18061cad 100644 --- a/Project.toml +++ b/Project.toml @@ -13,17 +13,22 @@ Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2" FixedPointNumbersStatisticsExt = "Statistics" [compat] +Aqua = "0.8" +Documenter = "1" +Random = "1" StableRNGs = "1" # Update this version specifier when Statistics.jl v1.11.2 is released. # https://github.com/JuliaStats/Statistics.jl/issues/165 Statistics = "< 1.11.2" +Test = "1" julia = "1" [extras] +Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595" Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4" StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3" Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2" Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" [targets] -test = ["Documenter", "StableRNGs", "Statistics", "Test"] +test = ["Aqua", "Documenter", "StableRNGs", "Statistics", "Test"] diff --git a/test/runtests.jl b/test/runtests.jl index cabb1b17..ebcc5efc 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -1,4 +1,4 @@ -using FixedPointNumbers, Test +using FixedPointNumbers, Test, Aqua if VERSION >= v"1.6.0-DEV.816" # JuliaLang/julia #36962 # FIXME @test isempty(detect_ambiguities(FixedPointNumbers)) @@ -6,6 +6,8 @@ else @test isempty(detect_ambiguities(FixedPointNumbers, Base, Core)) end +Aqua.test_all(FixedPointNumbers) + if Sys.ARCH === :x86_64 || Sys.ARCH === :i686 using Documenter doctest(FixedPointNumbers, manual = false) From 23b861af1d13eee2d6956296df84785f23810a7c Mon Sep 17 00:00:00 2001 From: hyrodium Date: Sat, 13 Apr 2024 21:25:28 +0900 Subject: [PATCH 2/5] add Aqua badge --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 0366ace5..35f9e202 100644 --- a/README.md +++ b/README.md @@ -3,6 +3,7 @@ [![Build Status][action-img]][action-url] [![Build Status][pkgeval-img]][pkgeval-url] [![coverage][codecov-img]][codecov-url] +[![Aqua QA](https://raw.githubusercontent.com/JuliaTesting/Aqua.jl/master/badge.svg)](https://github.com/JuliaTesting/Aqua.jl) This library implements fixed-point number types. A [fixed-point number] represents a fractional, or From de9153ffeb796c3158333120bfe5e4cd3d050d7e Mon Sep 17 00:00:00 2001 From: hyrodium Date: Sun, 14 Apr 2024 00:17:17 +0900 Subject: [PATCH 3/5] update Random.jl compat to support Julia v1.0 --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 18061cad..89beba48 100644 --- a/Project.toml +++ b/Project.toml @@ -15,7 +15,7 @@ FixedPointNumbersStatisticsExt = "Statistics" [compat] Aqua = "0.8" Documenter = "1" -Random = "1" +Random = "<0.0.1, 1" StableRNGs = "1" # Update this version specifier when Statistics.jl v1.11.2 is released. # https://github.com/JuliaStats/Statistics.jl/issues/165 From 68b9c21e8433f1bd692580878f86653b0fdf3af4 Mon Sep 17 00:00:00 2001 From: hyrodium Date: Sun, 14 Apr 2024 00:17:44 +0900 Subject: [PATCH 4/5] update Documenter.jl compat to support Julia v1.0 --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 89beba48..33f849ac 100644 --- a/Project.toml +++ b/Project.toml @@ -14,7 +14,7 @@ FixedPointNumbersStatisticsExt = "Statistics" [compat] Aqua = "0.8" -Documenter = "1" +Documenter = "0.27, 1" Random = "<0.0.1, 1" StableRNGs = "1" # Update this version specifier when Statistics.jl v1.11.2 is released. From 40c5e55a9824d070efd61980175816e3085b0c60 Mon Sep 17 00:00:00 2001 From: hyrodium Date: Sun, 14 Apr 2024 00:29:55 +0900 Subject: [PATCH 5/5] remove duplicated tests for ambiguities --- test/runtests.jl | 6 ------ 1 file changed, 6 deletions(-) diff --git a/test/runtests.jl b/test/runtests.jl index ebcc5efc..d037d440 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -1,11 +1,5 @@ using FixedPointNumbers, Test, Aqua -if VERSION >= v"1.6.0-DEV.816" # JuliaLang/julia #36962 # FIXME - @test isempty(detect_ambiguities(FixedPointNumbers)) -else - @test isempty(detect_ambiguities(FixedPointNumbers, Base, Core)) -end - Aqua.test_all(FixedPointNumbers) if Sys.ARCH === :x86_64 || Sys.ARCH === :i686