Skip to content

Enable package extension for Statistics #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 13, 2024
Merged

Enable package extension for Statistics #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8fea297
import Statistics.jl as a package extension and remove Requres.jl
hyrodium Apr 8, 2024
62d90cd
update for the version of Julia before v1.9
hyrodium Feb 12, 2024
f422be8
fix target in Project.toml
hyrodium Feb 12, 2024
c4bb7a6
fix `ext/FixedPointNumbersStatisticsExt.jl`
hyrodium Feb 12, 2024
8528da3
remove Statistics method for package exntension
hyrodium Apr 8, 2024
6c2a68c
add compat for Statistics.jl
hyrodium Apr 13, 2024
c4eee40
move precompile to the end of the module
hyrodium Apr 13, 2024
cc5d38b
update compat bound for Statistics.jl
hyrodium Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,22 @@ version = "0.9.0-dev"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"

[weakdeps]
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"

[extensions]
FixedPointNumbersStatisticsExt = "Statistics"

[compat]
# Update this version specifier when Statistics.jl v1.11.2 is released.
# https://github.com/JuliaStats/Statistics.jl/issues/165
Statistics = "< 1.11.2"
julia = "1"

[extras]
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Documenter", "Test"]
test = ["Documenter", "Statistics", "Test"]
13 changes: 13 additions & 0 deletions ext/FixedPointNumbersStatisticsExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
module FixedPointNumbersStatisticsExt

using FixedPointNumbers
import FixedPointNumbers: Treduce
using Statistics

import Statistics
if isdefined(Statistics, :_mean_promote)
# https://github.com/JuliaMath/FixedPointNumbers.jl/pull/183
Statistics._mean_promote(x::Real, y::FixedPoint) = Treduce(y)
end

end
9 changes: 4 additions & 5 deletions src/FixedPointNumbers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import Base: ==, <, <=, -, +, *, /, ~, isapprox,
signed, unsigned, copysign, flipsign, signbit,
length

import Statistics # for _mean_promote
import Random: Random, AbstractRNG, SamplerType, rand!

import Base.Checked: checked_neg, checked_abs, checked_add, checked_sub, checked_mul,
Expand Down Expand Up @@ -557,10 +556,6 @@ Base.mul_prod(x::FixedPoint, y::FixedPoint) = Treduce(x) * Treduce(y)
Base.reduce_empty(::typeof(Base.mul_prod), ::Type{F}) where {F<:FixedPoint} = one(Treduce)
Base.reduce_first(::typeof(Base.mul_prod), x::FixedPoint) = Treduce(x)

if isdefined(Statistics, :_mean_promote)
Statistics._mean_promote(x::Real, y::FixedPoint) = Treduce(y)
end

"""
sd, ad = scaledual(s::Number, a)

Expand Down Expand Up @@ -624,6 +619,10 @@ function rand!(r::AbstractRNG, A::Array{X}, ::SamplerType{X}) where {T, X <: Fix
A
end

if !isdefined(Base, :get_extension)
include("../ext/FixedPointNumbersStatisticsExt.jl")
end

if VERSION >= v"1.1" # work around https://github.com/JuliaLang/julia/issues/34121
include("precompile.jl")
_precompile_()
Expand Down