reduce places where Builtins are listed #58205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! |
vtjnash
force-pushed
the
jn/dedup-builtin-decls
branch
from
2de3c02 to
97cb5a6
Compare
vtjnash
force-pushed
the
jn/dedup-builtin-decls
branch
from
97cb5a6 to
ad44533
Compare
DRY code somewhat by consolidating builtin declarations to use a table or macro definition to auto-generate the required reflection metadata.
vtjnash
force-pushed
the
jn/dedup-builtin-decls
branch
from
ad44533 to
e0cfd8c
Compare
JeffBezanson
approved these changes
Apr 23, 2025
|
Nice! Note to everyone: don't take this as an invitation to add more builtins just because it's easy 😂 |
53 tasks
LebedevRI
pushed a commit
to LebedevRI/julia
that referenced
this pull request
May 2, 2025
DRY code somewhat by consolidating builtin declarations to use a table or macro definition to auto-generate the required reflection metadata. Mostly NFC, but does include a couple bugfixes caused by the consistency this enforces. Adding a new `Builtin` is now simply a matter of declaring it in `builtin_proto.h` and defining it in `builtins.c` and any relevant declarations are handled automatically.
58 tasks
vtjnash
added a commit
that referenced
this pull request
Jun 5, 2025
DRY code somewhat by consolidating builtin declarations to use a table or macro definition to auto-generate the required reflection metadata. Mostly NFC, but does include a couple bugfixes caused by the consistency this enforces. Adding a new `Builtin` is now simply a matter of declaring it in `builtin_proto.h` and defining it in `builtins.c` and any relevant declarations are handled automatically. (cherry picked from commit 907b201)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRY code somewhat by consolidating builtin declarations to use a table or macro definition to auto-generate the required reflection metadata. Mostly NFC, but does include a couple bugfixes caused by the consistency this enforces. Adding a new
Builtinis now simply a matter of declaring it inbuiltin_proto.hand defining it inbuiltins.cand any relevant declarations are handled automatically.