Skip to content

Commit 729cd6a

Browse files
committed
effects: fix Base.@_noub_meta
This had the incorrect number of arguments to `Expr(:purity, ...)` causing it to be silently ignored.
1 parent 24555b8 commit 729cd6a

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

base/essentials.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,8 @@ macro _noub_meta()
337337
#=:inaccessiblememonly=#false,
338338
#=:noub=#true,
339339
#=:noub_if_noinbounds=#false,
340-
#=:consistent_overlay=#false))
340+
#=:consistent_overlay=#false,
341+
#=:nortcall=#false))
341342
end
342343
# can be used in place of `@assume_effects :notaskstate` (supposed to be used for bootstrapping)
343344
macro _notaskstate_meta()

test/compiler/effects.jl

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -810,7 +810,12 @@ end
810810
# @test !Core.Compiler.is_nothrow(effects)
811811
# end
812812
#end
813-
#
813+
814+
@test Core.Compiler.is_noub(Base.infer_effects(Base._growbeg!, (Vector{Int}, Int)))
815+
@test Core.Compiler.is_noub(Base.infer_effects(Base._growbeg!, (Vector{Any}, Int)))
816+
@test Core.Compiler.is_noub(Base.infer_effects(Base._growend!, (Vector{Int}, Int)))
817+
@test Core.Compiler.is_noub(Base.infer_effects(Base._growend!, (Vector{Any}, Int)))
818+
814819
# tuple indexing
815820
# --------------
816821

0 commit comments

Comments
 (0)