Skip to content

Commit 688eac9

Browse files
committed
Fix bash on windows build and add instructions
temp
1 parent 9e3318c commit 688eac9

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

README.windows.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -436,3 +436,10 @@ running the resulting installer.
436436
inspect the list of loaded DLLs for bash, mintty, or another persistent
437437
process used to drive the build. Essentially *any* DLL outside of the Windows
438438
System directory is potential BLODA.
439+
440+
### Compiling for Bash on windows
441+
Bash on windows is an unsupported platform. However, compilation of julia is possible and functional. The packages required differ from standard ubuntu compilation as some packages are not installed by default in the bash on windows ubuntu image.
442+
443+
The missing packages are `byacc texinfo python-minimal automake`. With these installed and the standard ubuntu packages dependancies and julia currently compile without issue. The line below can be copied into your terminal to install all required packages.
444+
445+
`sudo apt-get -y install automake byacc texinfo python-minimal make gcc g++ gfortran perl wget m4 patch cmake pkg-config`

deps/llvm.mk

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -516,14 +516,14 @@ ifeq ($(LLVM_USE_CMAKE),1)
516516
$(LLVM_BUILDDIR_withtype)/build-configured: $(LLVM_SRC_DIR)/source-extracted | $(llvm_python_workaround) $(LIBCXX_DEPENDENCY)
517517
mkdir -p $(dir $@)
518518
cd $(dir $@) && \
519-
export PATH=$(llvm_python_workaround):$$PATH && \
519+
export PATH=$(llvm_python_workaround):"$$PATH" && \
520520
$(CMAKE) $(LLVM_SRC_DIR) $(CMAKE_GENERATOR_COMMAND) $(CMAKE_COMMON) $(LLVM_CMAKE) \
521521
|| { echo '*** To install a newer version of cmake, run contrib/download_cmake.sh ***' && false; }
522522
echo 1 > $@
523523

524524
$(LLVM_BUILDDIR_withtype)/build-compiled: $(LLVM_BUILDDIR_withtype)/build-configured | $(llvm_python_workaround)
525525
cd $(LLVM_BUILDDIR_withtype) && \
526-
export PATH=$(llvm_python_workaround):$$PATH && \
526+
export PATH=$(llvm_python_workaround):"$$PATH" && \
527527
$(if $(filter $(CMAKE_GENERATOR),make), \
528528
$(MAKE), \
529529
$(CMAKE) --build .)
@@ -534,13 +534,13 @@ else
534534
$(LLVM_BUILDDIR_withtype)/build-configured: $(LLVM_SRC_DIR)/source-extracted | $(llvm_python_workaround) $(LIBCXX_DEPENDENCY)
535535
mkdir -p $(dir $@)
536536
cd $(dir $@) && \
537-
export PATH=$(llvm_python_workaround):$$PATH && \
537+
export PATH=$(llvm_python_workaround):"$$PATH" && \
538538
$(LLVM_SRC_DIR)/configure $(CONFIGURE_COMMON) $(LLVM_FLAGS)
539539
echo 1 > $@
540540

541541
$(LLVM_BUILDDIR_withtype)/build-compiled: $(LLVM_BUILDDIR_withtype)/build-configured | $(llvm_python_workaround)
542542
cd $(LLVM_BUILDDIR_withtype) && \
543-
export PATH=$(llvm_python_workaround):$$PATH && \
543+
export PATH=$(llvm_python_workaround):"$$PATH" && \
544544
$(MAKE) $(LLVM_MFLAGS) $(MAKE_COMMON)
545545
echo 1 > $@
546546

@@ -549,7 +549,7 @@ endif # LLVM_USE_CMAKE
549549
$(LLVM_BUILDDIR_withtype)/build-checked: $(LLVM_BUILDDIR_withtype)/build-compiled | $(llvm_python_workaround)
550550
ifeq ($(OS),$(BUILD_OS))
551551
cd $(LLVM_BUILDDIR_withtype) && \
552-
export PATH=$(llvm_python_workaround):$$PATH && \
552+
export PATH=$(llvm_python_workaround):"$$PATH" && \
553553
$(if $(filter $(LLVM_USE_CMAKE),1), \
554554
$(CMAKE) --build . --target check, \
555555
$(MAKE) $(LLVM_MFLAGS) check)

0 commit comments

Comments
 (0)