stop throwing exception for test managers

Author: KristofferC

base/client.jl

@@ -128,10 +128,7 @@ end
 display_error(er) = display_error(er, [])
 function display_error(er, bt)
     print_with_color(Base.error_color(), STDERR, "ERROR: "; bold = true)
-    with_output_color(Base.error_color(), STDERR) do io
-        showerror(io, er, bt)
-        println(io)
-    end
+    Base.showerror(IOContext(STDERR, :limit => true), er, bt)
 end
 
 function eval_user_input(ast::ANY, show_value)

base/pkg/entry.jl

@@ -731,13 +731,6 @@ function test!(pkg::AbstractString,
     isfile(reqs_path) && resolve()
 end
 
-type PkgTestError <: Exception
-    msg::String
-end
-
-Base.show(io::IO, pkgerr::PkgTestError) = print(io, pkgerr.msg)
-Base.showerror(io::IO, ex::PkgTestError, bt; backtrace=true) = Base.showerror(io, ex)
-
 function test(pkgs::Vector{AbstractString}; coverage::Bool=false)
     errs = AbstractString[]
     nopkgs = AbstractString[]
@@ -758,8 +751,10 @@ function test(pkgs::Vector{AbstractString}; coverage::Bool=false)
         if !isempty(notests)
             push!(messages, "$(join(notests,", "," and ")) did not provide a test/runtests.jl file")
         end
-        throw(PkgTestError(join(messages, "and")))
+        Base.display_error(PkgError(join(messages, "and")))
+        !Base.isinteractive() && exit(1)
     end
+    return nothing
 end
 
 test(;coverage::Bool=false) = test(sort!(AbstractString[keys(installed())...]); coverage=coverage)

base/test.jl

@@ -382,8 +382,6 @@ function Base.show(io::IO, ex::TestSetException)
     print(io, ex.broken, " broken.")
 end
 
-Base.showerror(io::IO, ex::TestSetException, bt; backtrace=true) = show(io, ex)
-
 #-----------------------------------------------------------------------
 
 """
@@ -523,7 +521,9 @@ function finish(ts::DefaultTestSet)
     if total != total_pass + total_broken
         # Get all the error/failures and bring them along for the ride
         efs = filter_errors(ts)
-        throw(TestSetException(total_pass,total_fail,total_error, total_broken, efs))
+        Base.display_error(TestSetException(total_pass,total_fail,total_error, total_broken, efs))
+        println()
+        Base.isinteractive() ? (return nothing) : exit(1)
     end
 
     # return the testset so it is returned from the @testset macro

test/pkg.jl

@@ -273,15 +273,15 @@ temp_pkg_dir() do
             Pkg.test("IDoNotExist")
             error("unexpected")
         catch ex
-            @test isa(ex,Pkg.Entry.PkgTestError)
+            @test isa(ex,Pkg.PkgError)
             @test ex.msg == "IDoNotExist is not an installed package"
         end
 
         try
             Pkg.test("IDoNotExist1", "IDoNotExist2")
             error("unexpected")
         catch ex
-            @test isa(ex,Pkg.Entry.PkgTestError)
+            @test isa(ex,Pkg.PkgError)
             @test ex.msg == "IDoNotExist1 and IDoNotExist2 are not installed packages"
         end
     end
@@ -561,9 +561,3 @@ temp_pkg_dir() do
         @test contains(msg, "- $package\nRestart Julia to use the updated versions.")
     end
 end
-
-let
-    io = IOBuffer()
-    Base.showerror(io, Base.Pkg.Entry.PkgTestError("ppp"), backtrace())
-    @test !contains(String(take!(io)), "backtrace()")
-end

test/test.jl

@@ -395,9 +395,3 @@ end
 end
 @test_throws ErrorException @testset "$(error())" begin
 end
-
-let
-    io = IOBuffer()
-    Base.showerror(io, Test.TestSetException(1,2,3,4,Vector{Union{Base.Test.Error, Base.Test.Fail}}()), backtrace())
-    @test !contains(String(take!(io)), "backtrace()")
-end