Skip to content

Commit 4675b3b

Browse files
author
KristofferC
committed
Revert "Restrict binary ops for Diagonal and Symmetric to Number eltypes (#55251)"
This reverts commit 30573be.
1 parent 1ddd0b6 commit 4675b3b

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

stdlib/LinearAlgebra/src/diagonal.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,10 +226,10 @@ end
226226
(-)(Da::Diagonal, Db::Diagonal) = Diagonal(Da.diag - Db.diag)
227227

228228
for f in (:+, :-)
229-
@eval function $f(D::Diagonal{<:Number}, S::Symmetric)
229+
@eval function $f(D::Diagonal, S::Symmetric)
230230
return Symmetric($f(D, S.data), sym_uplo(S.uplo))
231231
end
232-
@eval function $f(S::Symmetric, D::Diagonal{<:Number})
232+
@eval function $f(S::Symmetric, D::Diagonal)
233233
return Symmetric($f(S.data, D), sym_uplo(S.uplo))
234234
end
235235
@eval function $f(D::Diagonal{<:Real}, H::Hermitian)

stdlib/LinearAlgebra/test/diagonal.jl

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1193,16 +1193,4 @@ end
11931193
end
11941194
end
11951195

1196-
@testset "+/- with block Symmetric/Hermitian" begin
1197-
for p in ([1 2; 3 4], [1 2+im; 2-im 4+2im])
1198-
m = SizedArrays.SizedArray{(2,2)}(p)
1199-
D = Diagonal(fill(m, 2))
1200-
for T in (Symmetric, Hermitian)
1201-
S = T(fill(m, 2, 2))
1202-
@test D + S == Array(D) + Array(S)
1203-
@test S + D == Array(S) + Array(D)
1204-
end
1205-
end
1206-
end
1207-
12081196
end # module TestDiagonal

0 commit comments

Comments
 (0)