From e240ea47b29eee305b1ce9ae52d282aa79530629 Mon Sep 17 00:00:00 2001 From: Kristoffer Date: Fri, 25 Apr 2025 11:54:20 +0200 Subject: [PATCH 1/5] WIP: Try use method deletion instead of custom sysimage --- .buildkite/runtests.yml | 12 +- .ci/Manifest.toml | 222 --------------------------- .ci/Project.toml | 8 - .ci/create_sysimage.jl | 16 -- .ci/create_sysimage_and_run_docs.jl | 6 - .ci/create_sysimage_and_run_tests.jl | 7 - .ci/run_tests.jl | 11 ++ .github/workflows/ci.yml | 3 +- docs/make.jl | 2 + test/abstractq.jl | 2 + test/addmul.jl | 2 + test/adjtrans.jl | 2 + test/bidiag.jl | 2 + test/bitarray.jl | 2 + test/blas.jl | 2 + test/bunchkaufman.jl | 2 + test/cholesky.jl | 2 + test/dense.jl | 2 + test/diagonal.jl | 2 + test/eigen.jl | 2 + test/factorization.jl | 3 + test/generic.jl | 2 + test/givens.jl | 2 + test/hessenberg.jl | 4 +- test/lapack.jl | 4 +- test/ldlt.jl | 2 + test/lq.jl | 2 + test/lu.jl | 2 + test/matmul.jl | 2 + test/pinv.jl | 2 + test/prune_old_LA.jl | 69 +++++++++ test/qr.jl | 2 + test/runtests.jl | 3 + test/schur.jl | 2 + test/special.jl | 2 + test/structuredbroadcast.jl | 3 + test/svd.jl | 2 + test/symmetric.jl | 2 + test/symmetriceigen.jl | 2 + test/triangular.jl | 2 + test/triangular2.jl | 2 + test/triangular3.jl | 2 + test/tridiag.jl | 2 + test/uniformscaling.jl | 2 + test/unitful.jl | 2 + 45 files changed, 162 insertions(+), 271 deletions(-) delete mode 100644 .ci/Manifest.toml delete mode 100644 .ci/Project.toml delete mode 100644 .ci/create_sysimage.jl delete mode 100644 .ci/create_sysimage_and_run_docs.jl delete mode 100644 .ci/create_sysimage_and_run_tests.jl create mode 100644 .ci/run_tests.jl create mode 100644 test/prune_old_LA.jl diff --git a/.buildkite/runtests.yml b/.buildkite/runtests.yml index a21eb633..72392a97 100644 --- a/.buildkite/runtests.yml +++ b/.buildkite/runtests.yml @@ -16,8 +16,7 @@ steps: version: "nightly" arch: "i686" command: | - julia --color=yes --project=.ci -e 'using Pkg; Pkg.instantiate()' - julia --color=yes --project=.ci .ci/create_sysimage_and_run_tests.jl + julia --color=yes .ci/run_tests.jl agents: queue: "julia" os: "linux" @@ -40,8 +39,7 @@ steps: - JuliaCI/julia#v1: version: "nightly" command: | - julia --color=yes --project=.ci --code-coverage=@ -e 'using Pkg; Pkg.instantiate()' - julia --color=yes --project=.ci --code-coverage=@ .ci/create_sysimage_and_run_tests.jl + julia --color=yes .ci/run_tests.jl agents: queue: "julia" os: "linux" @@ -55,8 +53,7 @@ steps: - JuliaCI/julia-coverage#v1: codecov: true command: | - julia --color=yes --project=.ci --code-coverage=@ -e 'using Pkg; Pkg.instantiate()' - julia --color=yes --project=.ci --code-coverage=@ .ci/create_sysimage_and_run_tests.jl + julia --color=yes .ci/run_tests.jl agents: queue: "julia" os: "macos" @@ -69,8 +66,7 @@ steps: - JuliaCI/julia-coverage#v1: codecov: true command: | - julia --color=yes --project=.ci --code-coverage=@ -e 'using Pkg; Pkg.instantiate()' - julia --color=yes --project=.ci --code-coverage=@ .ci/create_sysimage_and_run_tests.jl + julia --color=yes .ci/run_tests.jl agents: queue: "julia" os: "windows" diff --git a/.ci/Manifest.toml b/.ci/Manifest.toml deleted file mode 100644 index 4f888b42..00000000 --- a/.ci/Manifest.toml +++ /dev/null @@ -1,222 +0,0 @@ -# This file is machine-generated - editing it directly is not advised - -julia_version = "1.12.0-DEV" -manifest_format = "2.0" -project_hash = "b25b51369ac1c4a63619c6f77655347661ec5439" - -[[deps.ArgTools]] -uuid = "0dad84c5-d112-42e6-8d28-ef12dabb789f" -version = "1.1.2" - -[[deps.Artifacts]] -uuid = "56f22d72-fd6d-98f1-02f0-08ddc0907c33" -version = "1.11.0" - -[[deps.Base64]] -uuid = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f" -version = "1.11.0" - -[[deps.CompilerSupportLibraries_jll]] -deps = ["Artifacts", "Libdl"] -uuid = "e66e0078-7015-5450-92f7-15fbd957f2ae" -version = "1.3.0+1" - -[[deps.Dates]] -deps = ["Printf"] -uuid = "ade2ca70-3891-5945-98fb-dc099432e06a" -version = "1.11.0" - -[[deps.Distributed]] -deps = ["Random", "Serialization", "Sockets"] -uuid = "8ba89e20-285c-5b6f-9357-94700520ee1b" -version = "1.11.0" - -[[deps.Downloads]] -deps = ["ArgTools", "FileWatching", "LibCURL", "NetworkOptions"] -uuid = "f43a241f-c20a-4ad4-852c-f6b1247861c6" -version = "1.6.0" - -[[deps.FileWatching]] -uuid = "7b1f6079-737a-58dc-b8bc-7a2ca5c1b5ee" -version = "1.11.0" - -[[deps.Glob]] -git-tree-sha1 = "97285bbd5230dd766e9ef6749b80fc617126d496" -uuid = "c27321d9-0574-5035-807b-f59d2c89b15c" -version = "1.3.1" - -[[deps.InteractiveUtils]] -deps = ["Markdown"] -uuid = "b77e0a4c-d291-57a0-90e8-8db25a27a240" -version = "1.11.0" - -[[deps.JuliaSyntaxHighlighting]] -deps = ["StyledStrings"] -uuid = "ac6e5ff7-fb65-4e79-a425-ec3bc9c03011" -version = "1.12.0" - -[[deps.LazyArtifacts]] -deps = ["Artifacts", "Pkg"] -uuid = "4af54fe1-eca0-43a8-85a7-787d91b784e3" -version = "1.11.0" - -[[deps.LibCURL]] -deps = ["LibCURL_jll", "MozillaCACerts_jll"] -uuid = "b27032c2-a3e7-50c8-80cd-2d36dbcbfd21" -version = "0.6.4" - -[[deps.LibCURL_jll]] -deps = ["Artifacts", "LibSSH2_jll", "Libdl", "OpenSSL_jll", "Zlib_jll", "nghttp2_jll"] -uuid = "deac9b47-8bc7-5906-a0fe-35ac56dc84c0" -version = "8.11.1+1" - -[[deps.LibGit2]] -deps = ["LibGit2_jll", "NetworkOptions", "Printf", "SHA"] -uuid = "76f85450-5226-5b5a-8eaa-529ad045b433" -version = "1.11.0" - -[[deps.LibGit2_jll]] -deps = ["Artifacts", "LibSSH2_jll", "Libdl", "OpenSSL_jll"] -uuid = "e37daf67-58a4-590a-8e99-b0245dd2ffc5" -version = "1.9.0+0" - -[[deps.LibSSH2_jll]] -deps = ["Artifacts", "Libdl", "OpenSSL_jll"] -uuid = "29816b5a-b9ab-546f-933c-edad1886dfa8" -version = "1.11.3+1" - -[[deps.Libdl]] -uuid = "8f399da3-3557-5675-b5ff-fb832c97cbdb" -version = "1.11.0" - -[[deps.LinearAlgebra]] -deps = ["Libdl", "OpenBLAS_jll", "libblastrampoline_jll"] -path = ".." -uuid = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" -version = "1.12.0" - -[[deps.Logging]] -uuid = "56ddb016-857b-54e1-b83d-db4d58db5568" -version = "1.11.0" - -[[deps.Markdown]] -deps = ["Base64", "JuliaSyntaxHighlighting", "StyledStrings"] -uuid = "d6f4376e-aef5-505a-96c1-9c027394607a" -version = "1.11.0" - -[[deps.MozillaCACerts_jll]] -uuid = "14a3606d-f60d-562e-9121-12d972cd8159" -version = "2024.12.31" - -[[deps.NetworkOptions]] -uuid = "ca575930-c2e3-43a9-ace4-1e988b2c1908" -version = "1.3.0" - -[[deps.OpenBLAS_jll]] -deps = ["Artifacts", "CompilerSupportLibraries_jll", "Libdl"] -uuid = "4536629a-c528-5b80-bd46-f80d51c5b363" -version = "0.3.29+0" - -[[deps.OpenSSL_jll]] -deps = ["Artifacts", "Libdl"] -uuid = "458c3c95-2e84-50aa-8efc-19380b2a3a95" -version = "3.0.15+2" - -[[deps.PackageCompiler]] -deps = ["Artifacts", "Glob", "LazyArtifacts", "Libdl", "Pkg", "Printf", "RelocatableFolders", "TOML", "UUIDs", "p7zip_jll"] -git-tree-sha1 = "5d13e5b70011762b74f86fc08385303589f80272" -uuid = "9b87118b-4619-50d2-8e1e-99f35a4d4d9d" -version = "2.2.0" - -[[deps.Pkg]] -deps = ["Artifacts", "Dates", "Downloads", "FileWatching", "LibGit2", "Libdl", "Logging", "Markdown", "Printf", "Random", "SHA", "TOML", "Tar", "UUIDs", "p7zip_jll"] -uuid = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f" -version = "1.12.0" - - [deps.Pkg.extensions] - REPLExt = "REPL" - - [deps.Pkg.weakdeps] - REPL = "3fa0cd96-eef1-5676-8a61-b3b8758bbffb" - -[[deps.Printf]] -deps = ["Unicode"] -uuid = "de0858da-6303-5e67-8744-51eddeeeb8d7" -version = "1.11.0" - -[[deps.Random]] -deps = ["SHA"] -uuid = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" -version = "1.11.0" - -[[deps.RelocatableFolders]] -deps = ["SHA", "Scratch"] -git-tree-sha1 = "ffdaf70d81cf6ff22c2b6e733c900c3321cab864" -uuid = "05181044-ff0b-4ac5-8273-598c1e38db00" -version = "1.0.1" - -[[deps.SHA]] -uuid = "ea8e919c-243c-51af-8825-aaa63cd721ce" -version = "0.7.0" - -[[deps.Scratch]] -deps = ["Dates"] -git-tree-sha1 = "3bac05bc7e74a75fd9cba4295cde4045d9fe2386" -uuid = "6c6a2e73-6563-6170-7368-637461726353" -version = "1.2.1" - -[[deps.Serialization]] -uuid = "9e88b42a-f829-5b0c-bbe9-9e923198166b" -version = "1.11.0" - -[[deps.Sockets]] -uuid = "6462fe0b-24de-5631-8697-dd941f90decc" -version = "1.11.0" - -[[deps.StyledStrings]] -uuid = "f489334b-da3d-4c2e-b8f0-e476e12c162b" -version = "1.11.0" - -[[deps.TOML]] -deps = ["Dates"] -uuid = "fa267f1f-6049-4f14-aa54-33bafae1ed76" -version = "1.0.3" - -[[deps.Tar]] -deps = ["ArgTools", "SHA"] -uuid = "a4e569a6-e804-4fa4-b0f3-eef7a1d5b13e" -version = "1.10.0" - -[[deps.Test]] -deps = ["InteractiveUtils", "Logging", "Random", "Serialization"] -uuid = "8dfed614-e22c-5e08-85e1-65c5234f0b40" -version = "1.11.0" - -[[deps.UUIDs]] -deps = ["Random", "SHA"] -uuid = "cf7118a7-6976-5b1a-9a39-7adc72f591a4" -version = "1.11.0" - -[[deps.Unicode]] -uuid = "4ec0a83e-493e-50e2-b9ac-8f72acf5a8f5" -version = "1.11.0" - -[[deps.Zlib_jll]] -deps = ["Libdl"] -uuid = "83775a58-1f1d-513f-b197-d71354ab007a" -version = "1.3.1+2" - -[[deps.libblastrampoline_jll]] -deps = ["Artifacts", "Libdl"] -uuid = "8e850b90-86db-534c-a0d3-1478176c7d93" -version = "5.12.0+0" - -[[deps.nghttp2_jll]] -deps = ["Artifacts", "Libdl"] -uuid = "8e850ede-7688-5339-a07c-302acd2aaf8d" -version = "1.64.0+1" - -[[deps.p7zip_jll]] -deps = ["Artifacts", "Libdl"] -uuid = "3f19e933-33d8-53b3-aaab-bd5110c3b7a0" -version = "17.5.0+2" diff --git a/.ci/Project.toml b/.ci/Project.toml deleted file mode 100644 index 3916fe72..00000000 --- a/.ci/Project.toml +++ /dev/null @@ -1,8 +0,0 @@ -[deps] -Dates = "ade2ca70-3891-5945-98fb-dc099432e06a" -Distributed = "8ba89e20-285c-5b6f-9357-94700520ee1b" -LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" -PackageCompiler = "9b87118b-4619-50d2-8e1e-99f35a4d4d9d" -Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7" -Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" -Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" diff --git a/.ci/create_sysimage.jl b/.ci/create_sysimage.jl deleted file mode 100644 index 43aea023..00000000 --- a/.ci/create_sysimage.jl +++ /dev/null @@ -1,16 +0,0 @@ -using PackageCompiler, Libdl - -function create_sysimage_linear_algebra() - sysimage = tempname() * "." * Libdl.dlext - - if haskey(ENV, "BUILDKITE") - ncores = Sys.CPU_THREADS - else - ncores = ceil(Int, Sys.CPU_THREADS / 2) - end - - withenv("JULIA_IMAGE_THREADS" => ncores) do - create_sysimage(["LinearAlgebra", "Test", "Distributed", "Dates", "Printf", "Random"]; sysimage_path=sysimage, incremental=false, filter_stdlibs=true) - end - return sysimage, ncores -end diff --git a/.ci/create_sysimage_and_run_docs.jl b/.ci/create_sysimage_and_run_docs.jl deleted file mode 100644 index 376219bb..00000000 --- a/.ci/create_sysimage_and_run_docs.jl +++ /dev/null @@ -1,6 +0,0 @@ -include("create_sysimage.jl") -sysimage, ncores = create_sysimage_linear_algebra() -doc_file = joinpath(@__DIR__, "..", "docs", "make.jl") -withenv("JULIA_NUM_THREADS" => 1) do - run(`$(Base.julia_cmd()) --sysimage=$sysimage --project=$(dirname(doc_file)) $doc_file`) -end diff --git a/.ci/create_sysimage_and_run_tests.jl b/.ci/create_sysimage_and_run_tests.jl deleted file mode 100644 index 071fe1fd..00000000 --- a/.ci/create_sysimage_and_run_tests.jl +++ /dev/null @@ -1,7 +0,0 @@ -include("create_sysimage.jl") -sysimage, ncores = create_sysimage_linear_algebra() -current_dir = @__DIR__ -cmd = """Base.runtests(["LinearAlgebra"]; propagate_project=true, ncores=$ncores)""" -withenv("JULIA_NUM_THREADS" => 1) do - run(`$(Base.julia_cmd()) --sysimage=$sysimage --project=$current_dir -e $cmd`) -end diff --git a/.ci/run_tests.jl b/.ci/run_tests.jl new file mode 100644 index 00000000..8a54ef62 --- /dev/null +++ b/.ci/run_tests.jl @@ -0,0 +1,11 @@ +if haskey(ENV, "BUILDKITE") + ncores = Sys.CPU_THREADS +else + ncores = ceil(Int, Sys.CPU_THREADS / 2) +end + +proj = abspath(joinpath(@__DIR__, "..")) +cmd = """Base.runtests(["LinearAlgebra"]; propagate_project=true, ncores=$ncores)""" +withenv("JULIA_NUM_THREADS" => 1) do + run(`$(Base.julia_cmd()) --project=$proj --compiled-modules=existing -e $cmd`) +end diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7c423f04..c1611fbf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,9 +21,8 @@ jobs: version: 'nightly' - name: Generate docs run: | - julia --color=yes --project=.ci -e 'using Pkg; Pkg.instantiate()' julia --color=yes --project=docs -e 'using Pkg; Pkg.instantiate()' - julia --color=yes --project=.ci .ci/create_sysimage_and_run_docs.jl + julia --color=yes --project=docs --compiled-modules=existing docs/make.jl env: DOCUMENTER_KEY: ${{ secrets.DOCUMENTER_KEY }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/docs/make.jl b/docs/make.jl index 351fec43..a1d3a2d0 100644 --- a/docs/make.jl +++ b/docs/make.jl @@ -1,3 +1,5 @@ +include("../test/prune_old_LA.jl") + using LinearAlgebra using Documenter: DocMeta, makedocs, deploydocs, HTML diff --git a/test/abstractq.jl b/test/abstractq.jl index 302f2abf..c056de98 100644 --- a/test/abstractq.jl +++ b/test/abstractq.jl @@ -2,6 +2,8 @@ module TestAbstractQ +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test using LinearAlgebra using LinearAlgebra: AbstractQ, AdjointQ diff --git a/test/addmul.jl b/test/addmul.jl index 903e3b17..3ccd95af 100644 --- a/test/addmul.jl +++ b/test/addmul.jl @@ -2,6 +2,8 @@ module TestAddmul +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Base: rtoldefault using Test using LinearAlgebra diff --git a/test/adjtrans.jl b/test/adjtrans.jl index 50565583..30e6755a 100644 --- a/test/adjtrans.jl +++ b/test/adjtrans.jl @@ -2,6 +2,8 @@ module TestAdjointTranspose +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra const BASE_TEST_PATH = joinpath(Sys.BINDIR, "..", "share", "julia", "test") diff --git a/test/bidiag.jl b/test/bidiag.jl index fcd9de77..6ac6aad9 100644 --- a/test/bidiag.jl +++ b/test/bidiag.jl @@ -2,6 +2,8 @@ module TestBidiagonal +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: BlasReal, BlasFloat diff --git a/test/bitarray.jl b/test/bitarray.jl index 76fc21a6..02e5f2dd 100644 --- a/test/bitarray.jl +++ b/test/bitarray.jl @@ -1,3 +1,5 @@ +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using LinearAlgebra, Test, Random tc(r1::NTuple{N,Any}, r2::NTuple{N,Any}) where {N} = all(x->tc(x...), [zip(r1,r2)...]) diff --git a/test/blas.jl b/test/blas.jl index ff1d8bab..3f52e8c7 100644 --- a/test/blas.jl +++ b/test/blas.jl @@ -2,6 +2,8 @@ module TestBLAS +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: BlasReal, BlasComplex using Libdl: dlsym, dlopen diff --git a/test/bunchkaufman.jl b/test/bunchkaufman.jl index 68c519d1..29048713 100644 --- a/test/bunchkaufman.jl +++ b/test/bunchkaufman.jl @@ -2,6 +2,8 @@ module TestBunchKaufman +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, QRPivoted using Base: getproperty diff --git a/test/cholesky.jl b/test/cholesky.jl index 6a3fa45c..4a57320e 100644 --- a/test/cholesky.jl +++ b/test/cholesky.jl @@ -2,6 +2,8 @@ module TestCholesky +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, QRPivoted, PosDefException, RankDeficientException, chkfullrank diff --git a/test/dense.jl b/test/dense.jl index f71a53c2..1d6bcc72 100644 --- a/test/dense.jl +++ b/test/dense.jl @@ -2,6 +2,8 @@ module TestDense +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal using Test: GenericArray diff --git a/test/diagonal.jl b/test/diagonal.jl index 207e52d9..197c682f 100644 --- a/test/diagonal.jl +++ b/test/diagonal.jl @@ -2,6 +2,8 @@ module TestDiagonal +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: BlasFloat, BlasComplex diff --git a/test/eigen.jl b/test/eigen.jl index a82c7454..e44c1d19 100644 --- a/test/eigen.jl +++ b/test/eigen.jl @@ -2,6 +2,8 @@ module TestEigen +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, QRPivoted, UtiAUi! diff --git a/test/factorization.jl b/test/factorization.jl index f80c5197..10f935a6 100644 --- a/test/factorization.jl +++ b/test/factorization.jl @@ -1,6 +1,9 @@ # This file is a part of Julia. License is MIT: https://julialang.org/license module TestFactorization + +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra @testset "equality for factorizations - $f" for f in Any[ diff --git a/test/generic.jl b/test/generic.jl index 1a22c4ec..7be2a5a2 100644 --- a/test/generic.jl +++ b/test/generic.jl @@ -2,6 +2,8 @@ module TestGeneric +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using Test: GenericArray using LinearAlgebra: isbanded diff --git a/test/givens.jl b/test/givens.jl index 3726afa7..731642bc 100644 --- a/test/givens.jl +++ b/test/givens.jl @@ -2,6 +2,8 @@ module TestGivens +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: Givens, Rotation, givensAlgorithm diff --git a/test/hessenberg.jl b/test/hessenberg.jl index ebab3f29..ae5448f9 100644 --- a/test/hessenberg.jl +++ b/test/hessenberg.jl @@ -2,6 +2,8 @@ module TestHessenberg +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random const BASE_TEST_PATH = joinpath(Sys.BINDIR, "..", "share", "julia", "test") @@ -283,5 +285,5 @@ end @test Q2'Q2 ≈ I end end - + end # module TestHessenberg diff --git a/test/lapack.jl b/test/lapack.jl index 8bc20ffd..d75138ca 100644 --- a/test/lapack.jl +++ b/test/lapack.jl @@ -2,6 +2,8 @@ module TestLAPACK +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: BlasInt @@ -354,7 +356,7 @@ end @test_throws DimensionMismatch LAPACK.ormqr!('L','N',A,temp,B) @test_throws ArgumentError LAPACK.ormqr!('X','N',A,temp,B) @test_throws ArgumentError LAPACK.ormqr!('L','X',A,temp,B) - + A = rand(elty,10,11) A,tau = LAPACK.geqrf!(A) B = copy(A) diff --git a/test/ldlt.jl b/test/ldlt.jl index 51abf310..72d8ef05 100644 --- a/test/ldlt.jl +++ b/test/ldlt.jl @@ -2,6 +2,8 @@ module TestLDLT +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random Random.seed!(123) diff --git a/test/lq.jl b/test/lq.jl index af7ab600..acb7ce48 100644 --- a/test/lq.jl +++ b/test/lq.jl @@ -2,6 +2,8 @@ module TestLQ +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, rmul!, lmul! diff --git a/test/lu.jl b/test/lu.jl index a2abd358..ea47df5b 100644 --- a/test/lu.jl +++ b/test/lu.jl @@ -2,6 +2,8 @@ module TestLU +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: ldiv!, BlasReal, BlasInt, BlasFloat, rdiv! diff --git a/test/matmul.jl b/test/matmul.jl index bcb2857e..b7c4ff91 100644 --- a/test/matmul.jl +++ b/test/matmul.jl @@ -2,6 +2,8 @@ module TestMatmul +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Base: rtoldefault using Test, LinearAlgebra, Random using LinearAlgebra: mul!, Symmetric, Hermitian diff --git a/test/pinv.jl b/test/pinv.jl index c7268865..6874f162 100644 --- a/test/pinv.jl +++ b/test/pinv.jl @@ -2,6 +2,8 @@ module TestPinv +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random Random.seed!(12345) diff --git a/test/prune_old_LA.jl b/test/prune_old_LA.jl new file mode 100644 index 00000000..f628cddf --- /dev/null +++ b/test/prune_old_LA.jl @@ -0,0 +1,69 @@ +methods_to_delete = +[ +:adjoint +:transpose +:inv +:literal_pow +:\ +:/ +:isapprox +:copyto! +:* +:muladd +:copyto! +:isone +:kron! +:kron +:^ +:exp +:cis +:log +:sqrt +:cbrt +:inv +:cos +:sin +:sincos +:tan +:cosh +:sinh +:tanh +:acos +:asin +:atan +:acosh +:asinh +:atanh +:sec +:sech +:csc +:csch +:cot +:coth +:asec +:asech +:acsc +:acot +:acoth +:acsch +] + +let + LA = get(Base.loaded_modules, Base.PkgId(Base.UUID("37e2e46d-f89d-539d-b4ee-838fcccc9c8e"), "LinearAlgebra"), nothing) + if LA !== nothing + @assert hasmethod(*, Tuple{Matrix{Float64}, Matrix{Float64}}) + for methss in methods_to_delete + meths = getglobal(Base, methss) + for meth in methods(meths) + if meth.module === LA + Base.delete_method(meth) + end + end + end + end + Base.unreference_module(Base.PkgId(Base.UUID("37e2e46d-f89d-539d-b4ee-838fcccc9c8e"), "LinearAlgebra")) +end + +@assert !hasmethod(*, Tuple{Matrix{Float64}, Matrix{Float64}}) + +pruned_old_LA = true diff --git a/test/qr.jl b/test/qr.jl index b6e9ce3a..94a171f0 100644 --- a/test/qr.jl +++ b/test/qr.jl @@ -2,6 +2,8 @@ module TestQR +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, QRPivoted, rmul!, lmul! diff --git a/test/runtests.jl b/test/runtests.jl index 49df0743..d9539fba 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -1,4 +1,7 @@ # This file is a part of Julia. License is MIT: https://julialang.org/license + +include("prune_old_LA.jl") + using Test, LinearAlgebra for file in readlines(joinpath(@__DIR__, "testgroups")) diff --git a/test/schur.jl b/test/schur.jl index f3d494fb..ff459019 100644 --- a/test/schur.jl +++ b/test/schur.jl @@ -2,6 +2,8 @@ module TestSchur +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, QRPivoted diff --git a/test/special.jl b/test/special.jl index d1d4cbd6..9a9d38c4 100644 --- a/test/special.jl +++ b/test/special.jl @@ -2,6 +2,8 @@ module TestSpecial +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: rmul!, BandIndex diff --git a/test/structuredbroadcast.jl b/test/structuredbroadcast.jl index 5b5cc0cd..5351fd06 100644 --- a/test/structuredbroadcast.jl +++ b/test/structuredbroadcast.jl @@ -1,6 +1,9 @@ # This file is a part of Julia. License is MIT: https://julialang.org/license module TestStructuredBroadcast + +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra const BASE_TEST_PATH = joinpath(Sys.BINDIR, "..", "share", "julia", "test") diff --git a/test/svd.jl b/test/svd.jl index 33c02517..f2c52cc4 100644 --- a/test/svd.jl +++ b/test/svd.jl @@ -2,6 +2,8 @@ module TestSVD +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, QRPivoted diff --git a/test/symmetric.jl b/test/symmetric.jl index f653f4b9..92ff4001 100644 --- a/test/symmetric.jl +++ b/test/symmetric.jl @@ -2,6 +2,8 @@ module TestSymmetric +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random const BASE_TEST_PATH = joinpath(Sys.BINDIR, "..", "share", "julia", "test") diff --git a/test/symmetriceigen.jl b/test/symmetriceigen.jl index 7a2b88a5..a1336153 100644 --- a/test/symmetriceigen.jl +++ b/test/symmetriceigen.jl @@ -2,6 +2,8 @@ module TestSymmetricEigen +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra using LinearAlgebra: DivideAndConquer, QRIteration, RobustRepresentations diff --git a/test/triangular.jl b/test/triangular.jl index 02c58df7..a4a18c91 100644 --- a/test/triangular.jl +++ b/test/triangular.jl @@ -2,6 +2,8 @@ module TestTriangular +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random using LinearAlgebra: errorbounds, transpose!, BandIndex diff --git a/test/triangular2.jl b/test/triangular2.jl index 0d0c603c..ab5d16d5 100644 --- a/test/triangular2.jl +++ b/test/triangular2.jl @@ -2,6 +2,8 @@ module TestTriangularReal +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Random Random.seed!(123) diff --git a/test/triangular3.jl b/test/triangular3.jl index c2b7306c..fc82ebf3 100644 --- a/test/triangular3.jl +++ b/test/triangular3.jl @@ -2,6 +2,8 @@ module TestTriangularComplex +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Random Random.seed!(123) diff --git a/test/tridiag.jl b/test/tridiag.jl index 115b7ab2..084e94a5 100644 --- a/test/tridiag.jl +++ b/test/tridiag.jl @@ -2,6 +2,8 @@ module TestTridiagonal +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random const BASE_TEST_PATH = joinpath(Sys.BINDIR, "..", "share", "julia", "test") diff --git a/test/uniformscaling.jl b/test/uniformscaling.jl index 10d427d1..bc79bd2c 100644 --- a/test/uniformscaling.jl +++ b/test/uniformscaling.jl @@ -2,6 +2,8 @@ module TestUniformscaling +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random const BASE_TEST_PATH = joinpath(Sys.BINDIR, "..", "share", "julia", "test") diff --git a/test/unitful.jl b/test/unitful.jl index 8d6c4260..4a9a2f3f 100644 --- a/test/unitful.jl +++ b/test/unitful.jl @@ -1,5 +1,7 @@ module TestUnitfulLinAlg +isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") + using Test, LinearAlgebra, Random Random.seed!(1234321) From 4e0201d4135e002b8bc4329ff5713ce8dfc6558d Mon Sep 17 00:00:00 2001 From: Kristoffer Date: Fri, 25 Apr 2025 14:14:53 +0200 Subject: [PATCH 2/5] fix name check --- test/abstractq.jl | 2 +- test/addmul.jl | 2 +- test/adjtrans.jl | 2 +- test/bidiag.jl | 2 +- test/bitarray.jl | 2 +- test/blas.jl | 2 +- test/bunchkaufman.jl | 2 +- test/cholesky.jl | 2 +- test/dense.jl | 2 +- test/diagonal.jl | 2 +- test/eigen.jl | 2 +- test/factorization.jl | 2 +- test/generic.jl | 2 +- test/givens.jl | 2 +- test/hessenberg.jl | 2 +- test/lapack.jl | 2 +- test/ldlt.jl | 2 +- test/lq.jl | 2 +- test/lu.jl | 2 +- test/matmul.jl | 2 +- test/pinv.jl | 2 +- test/qr.jl | 2 +- test/schur.jl | 2 +- test/special.jl | 2 +- test/structuredbroadcast.jl | 2 +- test/svd.jl | 2 +- test/symmetric.jl | 2 +- test/symmetriceigen.jl | 2 +- test/triangular.jl | 2 +- test/triangular2.jl | 2 +- test/triangular3.jl | 2 +- test/tridiag.jl | 2 +- test/uniformscaling.jl | 2 +- test/unitful.jl | 2 +- 34 files changed, 34 insertions(+), 34 deletions(-) diff --git a/test/abstractq.jl b/test/abstractq.jl index c056de98..ff1499ae 100644 --- a/test/abstractq.jl +++ b/test/abstractq.jl @@ -2,7 +2,7 @@ module TestAbstractQ -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test using LinearAlgebra diff --git a/test/addmul.jl b/test/addmul.jl index 3ccd95af..f6b49d4e 100644 --- a/test/addmul.jl +++ b/test/addmul.jl @@ -2,7 +2,7 @@ module TestAddmul -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Base: rtoldefault using Test diff --git a/test/adjtrans.jl b/test/adjtrans.jl index 30e6755a..bdeaa697 100644 --- a/test/adjtrans.jl +++ b/test/adjtrans.jl @@ -2,7 +2,7 @@ module TestAdjointTranspose -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra diff --git a/test/bidiag.jl b/test/bidiag.jl index 6ac6aad9..209fb024 100644 --- a/test/bidiag.jl +++ b/test/bidiag.jl @@ -2,7 +2,7 @@ module TestBidiagonal -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: BlasReal, BlasFloat diff --git a/test/bitarray.jl b/test/bitarray.jl index 02e5f2dd..a185873e 100644 --- a/test/bitarray.jl +++ b/test/bitarray.jl @@ -1,4 +1,4 @@ -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using LinearAlgebra, Test, Random diff --git a/test/blas.jl b/test/blas.jl index 3f52e8c7..b7f4a03a 100644 --- a/test/blas.jl +++ b/test/blas.jl @@ -2,7 +2,7 @@ module TestBLAS -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: BlasReal, BlasComplex diff --git a/test/bunchkaufman.jl b/test/bunchkaufman.jl index 29048713..cf4fa488 100644 --- a/test/bunchkaufman.jl +++ b/test/bunchkaufman.jl @@ -2,7 +2,7 @@ module TestBunchKaufman -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, QRPivoted diff --git a/test/cholesky.jl b/test/cholesky.jl index 4a57320e..c03ec3f0 100644 --- a/test/cholesky.jl +++ b/test/cholesky.jl @@ -2,7 +2,7 @@ module TestCholesky -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, QRPivoted, diff --git a/test/dense.jl b/test/dense.jl index 1d6bcc72..ee659748 100644 --- a/test/dense.jl +++ b/test/dense.jl @@ -2,7 +2,7 @@ module TestDense -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal diff --git a/test/diagonal.jl b/test/diagonal.jl index 197c682f..2b7cfd4d 100644 --- a/test/diagonal.jl +++ b/test/diagonal.jl @@ -2,7 +2,7 @@ module TestDiagonal -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: BlasFloat, BlasComplex diff --git a/test/eigen.jl b/test/eigen.jl index e44c1d19..67e58d34 100644 --- a/test/eigen.jl +++ b/test/eigen.jl @@ -2,7 +2,7 @@ module TestEigen -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, QRPivoted, UtiAUi! diff --git a/test/factorization.jl b/test/factorization.jl index 10f935a6..b215c246 100644 --- a/test/factorization.jl +++ b/test/factorization.jl @@ -2,7 +2,7 @@ module TestFactorization -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra diff --git a/test/generic.jl b/test/generic.jl index 7be2a5a2..7805662c 100644 --- a/test/generic.jl +++ b/test/generic.jl @@ -2,7 +2,7 @@ module TestGeneric -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using Test: GenericArray diff --git a/test/givens.jl b/test/givens.jl index 731642bc..fb09ec4e 100644 --- a/test/givens.jl +++ b/test/givens.jl @@ -2,7 +2,7 @@ module TestGivens -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: Givens, Rotation, givensAlgorithm diff --git a/test/hessenberg.jl b/test/hessenberg.jl index ae5448f9..91f6d155 100644 --- a/test/hessenberg.jl +++ b/test/hessenberg.jl @@ -2,7 +2,7 @@ module TestHessenberg -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random diff --git a/test/lapack.jl b/test/lapack.jl index d75138ca..12ed2145 100644 --- a/test/lapack.jl +++ b/test/lapack.jl @@ -2,7 +2,7 @@ module TestLAPACK -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: BlasInt diff --git a/test/ldlt.jl b/test/ldlt.jl index 72d8ef05..3454ef43 100644 --- a/test/ldlt.jl +++ b/test/ldlt.jl @@ -2,7 +2,7 @@ module TestLDLT -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random diff --git a/test/lq.jl b/test/lq.jl index acb7ce48..0d55f84f 100644 --- a/test/lq.jl +++ b/test/lq.jl @@ -2,7 +2,7 @@ module TestLQ -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, rmul!, lmul! diff --git a/test/lu.jl b/test/lu.jl index ea47df5b..ba869032 100644 --- a/test/lu.jl +++ b/test/lu.jl @@ -2,7 +2,7 @@ module TestLU -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: ldiv!, BlasReal, BlasInt, BlasFloat, rdiv! diff --git a/test/matmul.jl b/test/matmul.jl index b7c4ff91..d9635123 100644 --- a/test/matmul.jl +++ b/test/matmul.jl @@ -2,7 +2,7 @@ module TestMatmul -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Base: rtoldefault using Test, LinearAlgebra, Random diff --git a/test/pinv.jl b/test/pinv.jl index 6874f162..ecee397a 100644 --- a/test/pinv.jl +++ b/test/pinv.jl @@ -2,7 +2,7 @@ module TestPinv -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random diff --git a/test/qr.jl b/test/qr.jl index 94a171f0..2b121ca4 100644 --- a/test/qr.jl +++ b/test/qr.jl @@ -2,7 +2,7 @@ module TestQR -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, QRPivoted, rmul!, lmul! diff --git a/test/schur.jl b/test/schur.jl index ff459019..e0a16b80 100644 --- a/test/schur.jl +++ b/test/schur.jl @@ -2,7 +2,7 @@ module TestSchur -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, QRPivoted diff --git a/test/special.jl b/test/special.jl index 9a9d38c4..a337983c 100644 --- a/test/special.jl +++ b/test/special.jl @@ -2,7 +2,7 @@ module TestSpecial -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: rmul!, BandIndex diff --git a/test/structuredbroadcast.jl b/test/structuredbroadcast.jl index 5351fd06..b8b16a8d 100644 --- a/test/structuredbroadcast.jl +++ b/test/structuredbroadcast.jl @@ -2,7 +2,7 @@ module TestStructuredBroadcast -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra diff --git a/test/svd.jl b/test/svd.jl index f2c52cc4..fdcfcb30 100644 --- a/test/svd.jl +++ b/test/svd.jl @@ -2,7 +2,7 @@ module TestSVD -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, QRPivoted diff --git a/test/symmetric.jl b/test/symmetric.jl index 92ff4001..6e4a5029 100644 --- a/test/symmetric.jl +++ b/test/symmetric.jl @@ -2,7 +2,7 @@ module TestSymmetric -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random diff --git a/test/symmetriceigen.jl b/test/symmetriceigen.jl index a1336153..36b69d29 100644 --- a/test/symmetriceigen.jl +++ b/test/symmetriceigen.jl @@ -2,7 +2,7 @@ module TestSymmetricEigen -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra using LinearAlgebra: DivideAndConquer, QRIteration, RobustRepresentations diff --git a/test/triangular.jl b/test/triangular.jl index a4a18c91..642411fe 100644 --- a/test/triangular.jl +++ b/test/triangular.jl @@ -2,7 +2,7 @@ module TestTriangular -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random using LinearAlgebra: errorbounds, transpose!, BandIndex diff --git a/test/triangular2.jl b/test/triangular2.jl index ab5d16d5..8740ff8d 100644 --- a/test/triangular2.jl +++ b/test/triangular2.jl @@ -2,7 +2,7 @@ module TestTriangularReal -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Random diff --git a/test/triangular3.jl b/test/triangular3.jl index fc82ebf3..9a29d681 100644 --- a/test/triangular3.jl +++ b/test/triangular3.jl @@ -2,7 +2,7 @@ module TestTriangularComplex -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Random diff --git a/test/tridiag.jl b/test/tridiag.jl index 084e94a5..423012c8 100644 --- a/test/tridiag.jl +++ b/test/tridiag.jl @@ -2,7 +2,7 @@ module TestTridiagonal -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random diff --git a/test/uniformscaling.jl b/test/uniformscaling.jl index bc79bd2c..21bd4b80 100644 --- a/test/uniformscaling.jl +++ b/test/uniformscaling.jl @@ -2,7 +2,7 @@ module TestUniformscaling -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random diff --git a/test/unitful.jl b/test/unitful.jl index 4a9a2f3f..87c153c2 100644 --- a/test/unitful.jl +++ b/test/unitful.jl @@ -1,6 +1,6 @@ module TestUnitfulLinAlg -isdefined(Main, :pruned_LA) || @eval Main include("prune_old_LA.jl") +isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl") using Test, LinearAlgebra, Random From 6f66af230998ab03cce3c3dd02c766a9cf861998 Mon Sep 17 00:00:00 2001 From: Kristoffer Date: Fri, 25 Apr 2025 15:52:43 +0200 Subject: [PATCH 3/5] add back code coverage --- .buildkite/runtests.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.buildkite/runtests.yml b/.buildkite/runtests.yml index 72392a97..936dc49d 100644 --- a/.buildkite/runtests.yml +++ b/.buildkite/runtests.yml @@ -16,7 +16,7 @@ steps: version: "nightly" arch: "i686" command: | - julia --color=yes .ci/run_tests.jl + julia --color=yes --code-coverage=@ .ci/run_tests.jl agents: queue: "julia" os: "linux" @@ -39,7 +39,7 @@ steps: - JuliaCI/julia#v1: version: "nightly" command: | - julia --color=yes .ci/run_tests.jl + julia --color=yes --code-coverage=@ .ci/run_tests.jl agents: queue: "julia" os: "linux" @@ -53,7 +53,7 @@ steps: - JuliaCI/julia-coverage#v1: codecov: true command: | - julia --color=yes .ci/run_tests.jl + julia --color=yes --code-coverage=@ .ci/run_tests.jl agents: queue: "julia" os: "macos" @@ -66,7 +66,7 @@ steps: - JuliaCI/julia-coverage#v1: codecov: true command: | - julia --color=yes .ci/run_tests.jl + julia --color=yes --code-coverage=@ .ci/run_tests.jl agents: queue: "julia" os: "windows" From ba5b0052c1b75678dac59c658499ca4d31cba699 Mon Sep 17 00:00:00 2001 From: Kristoffer Date: Fri, 25 Apr 2025 15:53:06 +0200 Subject: [PATCH 4/5] integration check that we are actually running the custom LA code --- src/LinearAlgebra.jl | 2 +- src/tridiag.jl | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/LinearAlgebra.jl b/src/LinearAlgebra.jl index 30aa23d0..6ef3b133 100644 --- a/src/LinearAlgebra.jl +++ b/src/LinearAlgebra.jl @@ -287,7 +287,7 @@ julia> B = view(A, 2:2:4) 4 julia> LinearAlgebra.stride1(B) -2 +3 ``` """ stride1(x) = stride(x,1) diff --git a/src/tridiag.jl b/src/tridiag.jl index c2290104..2472315c 100644 --- a/src/tridiag.jl +++ b/src/tridiag.jl @@ -104,7 +104,7 @@ julia> B = reshape([[1 2; 2 3], [1 2; 3 4], [1 3; 2 4], [1 2; 2 3]], 2, 2); julia> SymTridiagonal(B) 2×2 SymTridiagonal{Matrix{Int64}, Vector{Matrix{Int64}}}: [1 2; 2 3] [1 3; 2 4] - [1 2; 3 4] [1 2; 2 3] + [1 2; 3 4] [1 2; 2 1] ``` """ function (::Type{SymTri})(A::AbstractMatrix) where {SymTri <: SymTridiagonal} @@ -138,6 +138,7 @@ AbstractMatrix{T}(S::SymTridiagonal) where {T} = SymTridiagonal{T}(S) AbstractMatrix{T}(S::SymTridiagonal{T}) where {T} = copy(S) function Matrix{T}(M::SymTridiagonal) where T + error() n = size(M, 1) Mf = Matrix{T}(undef, n, n) n == 0 && return Mf From 037ff2f49f7d6e149fd790c538d735dfb302a2ce Mon Sep 17 00:00:00 2001 From: Kristoffer Date: Fri, 25 Apr 2025 16:04:58 +0200 Subject: [PATCH 5/5] Revert "integration check that we are actually running the custom LA code" This reverts commit ba5b0052c1b75678dac59c658499ca4d31cba699. --- src/LinearAlgebra.jl | 2 +- src/tridiag.jl | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/LinearAlgebra.jl b/src/LinearAlgebra.jl index 6ef3b133..30aa23d0 100644 --- a/src/LinearAlgebra.jl +++ b/src/LinearAlgebra.jl @@ -287,7 +287,7 @@ julia> B = view(A, 2:2:4) 4 julia> LinearAlgebra.stride1(B) -3 +2 ``` """ stride1(x) = stride(x,1) diff --git a/src/tridiag.jl b/src/tridiag.jl index 2472315c..c2290104 100644 --- a/src/tridiag.jl +++ b/src/tridiag.jl @@ -104,7 +104,7 @@ julia> B = reshape([[1 2; 2 3], [1 2; 3 4], [1 3; 2 4], [1 2; 2 3]], 2, 2); julia> SymTridiagonal(B) 2×2 SymTridiagonal{Matrix{Int64}, Vector{Matrix{Int64}}}: [1 2; 2 3] [1 3; 2 4] - [1 2; 3 4] [1 2; 2 1] + [1 2; 3 4] [1 2; 2 3] ``` """ function (::Type{SymTri})(A::AbstractMatrix) where {SymTri <: SymTridiagonal} @@ -138,7 +138,6 @@ AbstractMatrix{T}(S::SymTridiagonal) where {T} = SymTridiagonal{T}(S) AbstractMatrix{T}(S::SymTridiagonal{T}) where {T} = copy(S) function Matrix{T}(M::SymTridiagonal) where T - error() n = size(M, 1) Mf = Matrix{T}(undef, n, n) n == 0 && return Mf