Added acyclic coloring #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The find_edge method has been reverted back to the old version with a worst case running time of O(size of E) where E is the edge set of graph g. The primary reason is that while the function can be optimized by returning a new edge, the ambiguity between which vertex is the source and which one is the destination breaks the disjoint set function as `Edge 1 => 2` is treated differently compared to `Edge 2=>1`.
TODO: add tests for checking condition 2 of acyclic coloring (all cycles of size 3 or more should have atleast 3 colors)
|
I want to approve this PR just for the artistic drawings, but I'll restrain myself |
|
Those renderings, A+. |
matbesancon
reviewed
Aug 13, 2019
matbesancon
reviewed
Aug 13, 2019
matbesancon
reviewed
Aug 13, 2019
matbesancon
reviewed
Aug 13, 2019
|
@pkj-m to be |
matbesancon
reviewed
Aug 13, 2019
matbesancon
reviewed
Aug 13, 2019
matbesancon
reviewed
Aug 13, 2019
matbesancon
reviewed
Aug 13, 2019
| A_graph = matrix2graph(_A, partition_by_rows) | ||
| color_graph(A_graph,alg) | ||
| end | ||
| abstract type SparseDiffToolsColoringAlgorithm <: ArrayInterface.ColoringAlgorithm end |
There was a problem hiding this comment.
Is this abstract type needed? Maybe the supertype from ArrayInterface is enough
There was a problem hiding this comment.
I'm not sure why we implemented it this way. Maybe @ChrisRackauckas can throw some light over it?
There was a problem hiding this comment.
Makes it not type piracy
matbesancon
reviewed
Aug 13, 2019
Co-Authored-By: Mathieu Besançon <[email protected]>
Co-Authored-By: Mathieu Besançon <[email protected]>
Co-Authored-By: Mathieu Besançon <[email protected]>
Co-Authored-By: Mathieu Besançon <[email protected]>
matbesancon
reviewed
Aug 14, 2019
matbesancon
reviewed
Aug 17, 2019
matbesancon
reviewed
Aug 17, 2019
matbesancon
reviewed
Aug 17, 2019
matbesancon
reviewed
Aug 17, 2019
matbesancon
reviewed
Aug 21, 2019
matbesancon
reviewed
Aug 21, 2019
matbesancon
reviewed
Aug 21, 2019
matbesancon
reviewed
Aug 21, 2019
|
@pkj-m some few more comments, then it looks good |
Co-Authored-By: Mathieu Besançon <[email protected]>
Co-Authored-By: Mathieu Besançon <[email protected]>
Co-Authored-By: Mathieu Besançon <[email protected]>
Co-Authored-By: Mathieu Besançon <[email protected]>
|
@ChrisRackauckas @matbesancon can we merge this now? |
|
Good to me yes
…On Mon, Aug 26, 2019, 21:44 Pankaj Mishra ***@***.***> wrote:
@ChrisRackauckas <https://github.com/ChrisRackauckas> @matbesancon
<https://github.com/matbesancon> can we merge this now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#60>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB2FDMWBEJ4GIJP24PNKGB3QGQXAPANCNFSM4IJ3RQTA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows user to color graph using acyclic coloring algorithm.
The main difference between acyclic coloring and ordinary distance-1 coloring is that in the case of acyclic coloring, on top of the regular distance-1 coloring condition, there is an added condition that all the cycles in the graph have atleast 3 colors present.
Example to illustrate the difference:
TODO:
firstTreeToVisitwith eitheredgetype or find a more efficient way to identify the specific edge object instead of iterating over all edges#29