-
Notifications
You must be signed in to change notification settings - Fork 45
Remove dependencies #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's still running, so unfortunately just removing Cassette does not seem to fix the issues in DelayDiffEq. |
I merged the fix for the Int32/Int64 issues. The tests show that even with the reduced dependencies, the first test takes around 2-3 minutes to run on Win64, Mac, and Linux 64bit and around 1700 on Win32.Both Win32 and Win64 tests throw a |
The tests on Win32 and Win64 with the Julia nightlies do not throw any exceptions. Could it be some upstream issue in Zygote? Could that also explain the long compilation times? According to the README
But still, the times are just too large. |
I made Zygote an optional dependency. The only test that is running so far, the one on Win32 (Julia 1.1.1) indicates that the issues are caused by Zygote and/or the optional four functions |
@ChrisRackauckas Is this PR appropriate or should I change anything else? The tests seem to pass on AppVeyor now as well, I tested it in my own AppVeyor project: https://ci.appveyor.com/project/devmotion/sparsedifftools-jl |
We just need to update the README too. |
This PR removes the dependencies on Cassette and SpecialFunctions. I'm currently running a test on Win32 (https://ci.appveyor.com/project/devmotion/delaydiffeq-jl-ungfr/build/job/femutot54m17paay) to check if by removing the dependency on Cassette we can get rid of the compilation time issues of DelayDiffEq.