Bug fix in chunk-size controlled AD #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a logical bug present in the code which led to the program iterating over any added paddings at the end of the last chunk, and rewriting the values in the original Jacobian due to the buggy color_i wrapping condition. Also modified code for non-sparse compressed matrices to avoid using color_i variable completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a logical bug present in the code which
led to the program iterating over any
added paddings at the end of the last chunk, and
rewriting the values in the original Jacobian due
to the buggy
color_iwrapping condition.Also modified code for non-sparse compressed matrices
to avoid using
color_ivariable completely.