-
Notifications
You must be signed in to change notification settings - Fork 45
Closed
Description
It seems, the function in lines https://github.com/JuliaDiffEq/SparseDiffTools.jl/blob/master/src/differentiation/compute_jacobian_ad.jl#L10-L16 is equivalent to the bad example in https://docs.julialang.org/en/v1/manual/performance-tips/index.html#Types-with-values-as-parameters-1? Should it just be chunksize = max(maximum(colors), DEFAULT_CHUNK_SIZE)
in https://github.com/JuliaDiffEq/SparseDiffTools.jl/blob/master/src/differentiation/compute_jacobian_ad.jl#L27 instead? Or could the Val
instance still be helpful when calling generate_chunked_partials
?
But then still the same problem appears in https://github.com/JuliaDiffEq/SparseDiffTools.jl/blob/master/src/differentiation/compute_jacobian_ad.jl#L46?
Metadata
Metadata
Assignees
Labels
No labels