Skip to content

Conversation

@devmotion
Copy link
Member

The PR updates the CI setup a bit:

@devmotion devmotion mentioned this pull request Dec 6, 2024
@codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (c310fb5) to head (b9df396).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
- Coverage   89.57%   89.23%   -0.35%     
==========================================
  Files          11       11              
  Lines         969      975       +6     
==========================================
+ Hits          868      870       +2     
- Misses        101      105       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@devmotion devmotion mentioned this pull request Mar 31, 2025
@devmotion
Copy link
Member Author

Test failures were caused by a bug in NaNMath which was fixed in JuliaMath/NaNMath.jl#92.

@gdalle gdalle merged commit 382363a into master May 12, 2025
11 of 14 checks passed
@devmotion devmotion deleted the dw/ci branch May 12, 2025 21:55
@devmotion
Copy link
Member Author

@gdalle Thanks for merging but I generally prefer the ColPrac standard

PRs by people with merge rights should not be merged by people other than the author (just approved).

@gdalle
Copy link
Member

gdalle commented May 12, 2025

I was aware of it but there is no ColPack badge on this repo, should we add it?

@devmotion
Copy link
Member Author

The repo doesn't follow ColPrac officially, and I don't think it should be enforced. As I said, it's my general preference but it might not be shared by other contributors.

@gdalle
Copy link
Member

gdalle commented May 13, 2025

Judging by #749 it seems you're right! I'll keep it it mind for your PRs then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants