Move SIMD tests to a separate job and allow them to fail #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overall test failure when they fail. This is needed because they seem to be brittle.
Collaborator
|
:+1, but doesn't work on AV. Not sure how much it is worth testing on Windows though since all of this is pure Julia code. |
Member
Author
|
Ha. The test failure on Windows is actually a proper error in the test from #437 on 32 bit that I didn't notice because of all the SIMD errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid overall test failure when they fail. This is needed because they
seem to be brittle.
I'll open an issue about making the tests more reliable but we risk merging something breaking (correctness and not just performance) as long as we fail overall when the SIMD tests fail.