Skip to content

Conversation

@serenity4
Copy link
Collaborator

fT.name.mt.name was replaced by fT.name.singletonname in JuliaLang/julia#58131, which caused a breakage.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (2c33b9a) to head (b065c1b).
Report is 62 commits behind head on master.

Files with missing lines Patch % Lines
src/backedges.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #645   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           9      11    +2     
  Lines        1556    1593   +37     
======================================
- Misses       1556    1593   +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serenity4
Copy link
Collaborator Author

Seems like TypedSyntax is also broken through MethodAnalysis.jl. For this one though, the fix isn't as obvious because it used to access the method table from MethodList, and AFAIU it's no longer possible to do so.

Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it used to access the method table from MethodList, and AFAIU it's no longer possible to do so.

So it seems that we need to change the fundamental implementation strategy of MethodAnalysis?

@serenity4
Copy link
Collaborator Author

From what I understand, the method table was accessed for its backedges, and now these must be retrieved by other means. We now have them available via ((ml::MethodList).tn::Core.TypeName).backedges. I am working on a PR to update MethodAnalysis.

@serenity4
Copy link
Collaborator Author

This should fix it: timholy/MethodAnalysis.jl#52

@serenity4
Copy link
Collaborator Author

I don't see any downsides in merging this now, so we can have it part of the manual release. Hopefully the MethodAnalysis PR will get merged in a reasonable time frame so the TypedSyntax tests don't remain broken for too long.

@serenity4 serenity4 merged commit 0b3bb20 into JuliaDebug:master Jun 3, 2025
4 of 7 checks passed
@serenity4 serenity4 deleted the fix-one-mt branch June 3, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants